Last modified: 2010-05-15 14:36:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3603 - headscripts variable not hooked up to MonoBook skin
headscripts variable not hooked up to MonoBook skin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.6.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-04 21:52 UTC by Rob Lanphier (RobLa)
Modified: 2010-05-15 14:36 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Add "headscripts" variable to monobook (959 bytes, patch)
2005-10-04 21:54 UTC, Rob Lanphier (RobLa)
Details

Description Rob Lanphier (RobLa) 2005-10-04 21:52:43 UTC
The headscripts variable that Tim Starling added (
http://mail.wikipedia.org/pipermail/mediawiki-cvs/2005-August/010697.html ) is a
very useful addition for a plugin I'm working on.  However, it doesn't appear to
be hooked up in MonoBook (other skins seem to inherit from SkinTemplate.php just
fine).  This one line patch fixes that.

Patch forthcoming.  In essense, just adding <?php $this->html('headscripts') ?>
to MonoBook.php will do the trick.

Hopefully for 1.5 release.
Comment 1 Rob Lanphier (RobLa) 2005-10-04 21:54:51 UTC
Created attachment 937 [details]
Add "headscripts" variable to monobook
Comment 2 Gregory Szorc 2005-12-19 05:50:23 UTC
Could this please get put into the release branch of MediaWiki?  For developers
that need to include Javascript as part of extensions and special pages, it is
frustrating to release products that force users to modify the MediaWiki code
base.  The whole idea of the 'headscripts' variable is to allow developers to
just use $wgOut->addScript($foo) without having to get into the nitty-gritty of
editing skin files.  The very presence of the headscript variable and related
functions proves that this should be enabled in the skins.  It's absence is
obviously just an oversight.
Comment 3 Rob Church 2006-01-20 19:28:42 UTC
Fixed in CVS HEAD. Will check about backporting to 1.5 branch.
Comment 4 River Tarnell 2006-01-26 21:15:22 UTC
are you planning to back port this in the short term?  i need it for a 1.5
extension i'm writing - if you're too busy i'll do it myself.
Comment 5 Rob Church 2006-01-26 22:25:14 UTC
Not until I can be bothered to check, so probably quicker to do it yourself. ;-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links