Last modified: 2010-05-15 15:37:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3591 - OutputPage.php ignores $wgCookiePath, $wgCookieDomain
OutputPage.php ignores $wgCookiePath, $wgCookieDomain
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.5.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-10-04 00:04 UTC by Johannes Ernst
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Johannes Ernst 2005-10-04 00:04:02 UTC
Line 460 in OutputPage.php is:

    setcookie( $name, $val, $exp, '/' );

This hard-codes the path, and ignores the domain for cookies configured to as
$wgCookiePath, $wgCookieDomain in the settings. I suppose this is an oversight
(cookies set in all other places seem to use the settings).

The correct version would be:

    global $wgCookiePath, $wgCookieDomain;
    setcookie( $name, $val, $exp, $wgCookiePath, $wgCookieDomain );
Comment 1 Johannes Ernst 2005-10-06 17:37:18 UTC
still present in 1.5.0
Comment 2 Antoine "hashar" Musso (WMF) 2006-12-08 23:56:05 UTC
Got removed in the 1.6 branch.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links