Last modified: 2013-04-22 16:15:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37802, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35802 - Gerrit email title truncation over eager
Gerrit email title truncation over eager
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Chad H.
: upstream
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-07 20:32 UTC by Niklas Laxström
Modified: 2013-04-22 16:15 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2012-04-07 20:32:28 UTC 
E-mail title: [Gerrit] (bug 33564) transwiki import sometimes result in invalid tit... - change (mediawiki/core[master])


Change subject: (bug 33564) transwiki import sometimes result in invalid title


So truncation actually results in longer subject.
Comment 1 Chad H. 2012-06-28 13:09:51 UTC 
Should be pretty easy to fix in ChangeSubject.vm. I'm testing it locally then will submit to gerrit for review.

If it works, I'll submit the fix upstream as well. Thanks for reporting this.
Comment 2 Chad H. 2012-06-28 13:19:32 UTC 
Submitted for us in Gerrit change #13325.

Also submitted upstream.
Comment 3 Rob Lanphier 2013-01-30 21:57:27 UTC 
Chad's reverted upstream change: https://gerrit-review.googlesource.com/#/c/36540/
Comment 4 Andre Klapper 2013-02-19 19:30:54 UTC 
Upstream revert comment:  "The truncation failed when the subject length was 59, throwing StringIndexOutOfBoundsException and causing email formatting to abort with no message sent."

Curious if same problem happens in our applied downstream patch (Gerrit change #13325)?
Comment 5 Chad H. 2013-02-19 19:42:38 UTC 
I had reverted our custom patch out of caution.
Comment 6 christian 2013-02-20 10:51:46 UTC 
New fix was accepted upstream in commit 9fe238ec19d1ef5b16193b524e9b07cd031de46b
https://gerrit-review.googlesource.com/42424

Submitted downstream patch for us in 05ae70be072d95721572ceeb5d2a92751f5a81c6
https://gerrit.wikimedia.org/r/49987
Comment 7 Chad H. 2013-02-20 20:00:57 UTC 
This should now be fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links