Last modified: 2014-02-25 19:50:18 UTC
Testing head, any extensions that are from the git repo don't get version hashes, but the SVN ones do. Oversight?
I guess it is: /** * Return a string of the MediaWiki version with SVN revision if available. * * @param $flags String * @return mixed */ public static function getVersion( $flags = '' ) { global $wgVersion, $IP; wfProfileIn( __METHOD__ ); $info = self::getSvnInfo( $IP ); if ( !$info ) { $version = $wgVersion; } elseif( $flags === 'nodb' ) { $version = "$wgVersion (r{$info['checkout-rev']})"; } else { $version = $wgVersion . ' ' . wfMsg( 'version-svn-revision', isset( $info['directory-rev'] ) ? $info['directory-rev'] : '', $info['checkout-rev'] ); } wfProfileOut( __METHOD__ ); return $version; } vs for core: /** * Return a wikitext-formatted string of the MediaWiki version with a link to * the SVN revision or the git SHA1 of head if available. * Git is prefered over Svn * The fallback is just $wgVersion * * @return mixed */ public static function getVersionLinked() { global $wgVersion; wfProfileIn( __METHOD__ ); if( $gitVersion = self::getVersionLinkedGit() ) { $v = $gitVersion; } elseif( $svnVersion = self::getVersionLinkedSvn() ) { $v = $svnVersion; } else { $v = $wgVersion; // fallback } wfProfileOut( __METHOD__ ); return $v; }
Fix pending review in Git changeset #4332.
Gerrit change #4332 is better :)
Yaay :)
And merged.