Last modified: 2010-05-15 15:37:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3487 - Category contents is not shown if the preview is at the bottom
Category contents is not shown if the preview is at the bottom
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.5.x
All All
: Normal minor with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: html
  Show dependency treegraph
 
Reported: 2005-09-17 12:43 UTC by Dave Miller (ProgMania)
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Dave Miller (ProgMania) 2005-09-17 12:43:04 UTC
TOP
-------------------------------------------------------------------------------
$wgOut->addHTML( '<div id="wikiPreview">' );
if ( 'preview' == $formtype) {
	$previewOutput = $this->getPreviewText( $isConflict, $isCssJsSubpage );
	if ( $wgUser->getOption('previewontop' ) ) {
		$wgOut->addHTML( $previewOutput );
		if($this->mTitle->getNamespace() == NS_CATEGORY) {
			$this->mArticle->closeShowCategory();
		}				
		$wgOut->addHTML( "<br style=\"clear:both;\" />\n" );
	}
}
$wgOut->addHTML( '</div>' );
-------------------------------------------------------------------------------

BOTTOM
-------------------------------------------------------------------------------
if ( $formtype == 'preview' && !$wgUser->getOption( 'previewontop' ) ) {
	$wgOut->addHTML( '<div id="wikiPreview">' . $previewOutput . '</div>' );
}
-------------------------------------------------------------------------------

I.e. this is missing:
	if($this->mTitle->getNamespace() == NS_CATEGORY) {
		$this->mArticle->closeShowCategory();
	}

Also, if it's at the bottom. "<div id="wikiPreview"></div>" is still output at the top, resulting 
in two divs with the same id. (I don't know if this causes a problem for scripting or not but it's 
still unnecessary.)

(I also noticed openShowCategory() not called - although it is currently blank, if anything was 
added to it then the preview would be different to the action view.)
Comment 1 Brion Vibber 2005-11-03 22:44:25 UTC
Fixed in HEAD for 1.6.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links