Last modified: 2012-04-16 17:34:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36852, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34852 - Allow for <gallery> thumbnail links to be overridden and point to both internal and external links.
Allow for <gallery> thumbnail links to be overridden and point to both intern...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.20.x
All All
: Normal enhancement with 1 vote (vote)
: 1.20.0 release
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-01 13:51 UTC by kim
Modified: 2012-04-16 17:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch (211.54 KB, patch)
2012-03-01 13:51 UTC, kim
Details

Description kim 2012-03-01 13:51:43 UTC
Created attachment 10146 [details]
patch

I have created a patch which adds an optional parameter |link= to the <gallery> tag.

Here are a couple of examples.

<gallery>
File:20120106_001.jpg|link=[[DisplayLine]]
</gallery>

<gallery>
File:20120106_001.jpg|my caption|alt=my alt text|link=http://bugzilla.wikimedia.org
</gallery>

this would cause the link on the thumbnails rendered by the gallery tag to link to a custom page/url instead of the actual media/image.

The patch is fairly small, only touches two files. I would personally have commited these files to trunk, however i don't have core commit access, and i figured submitting it as a patch would carry less overhead.
Comment 1 Sumana Harihareswara 2012-03-02 02:06:21 UTC
Thanks for the patch, Kim! I made you a member of the group that can edit Bugzilla bugs, so if you have any future patches to core (between now and the Git migration) you can add the "patch" and "need-review" keywords to signal that your patch awaits inspection.
Comment 2 kim 2012-03-26 12:28:40 UTC
Would probably be better if this patch is implemented sooner rather than later, as it is sensitive to code change.
Comment 3 kim 2012-04-10 10:54:19 UTC
Added patch for code review.
https://gerrit.wikimedia.org/r/#change,4609

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links