Last modified: 2006-11-14 03:01:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 348 - File upload doesn't quite validate names right
File upload doesn't quite validate names right
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2004-09-03 03:29 UTC by Timwi
Modified: 2006-11-14 03:01 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
kawaser5.jpeg (85.73 KB, patch)
2006-11-14 01:42 UTC, admin
Details

Description Timwi 2004-09-03 03:29:03 UTC
BUG MIGRATED FROM SOURCEFORGE
http://sourceforge.net/tracker/index.php?func=detail&aid=720843&group_id=34373&atid=411192
Originally submitted by Brion Vibber (vibber)<a href="/help/icon_legend.php?context=user_wantsdonations&amp;user_id=446709&amp;return_to=%2F"><IMG src="http://images.sourceforge.net/images/icons/donate.png" alt="Accepting Donations" border="0" width="16" height="16"></a>  2003-04-14 02:26


Circumstance:
A file is uploaded whose name is not a valid wiki page
title (invalid characters, such as #). The filename is
munged with the intent of making a legal title.

Expected behavior:
Even hideously deformed title should be turned into
something legal.

Actual behavior:
Some, such as containing #, do not result in a legal
title. The resulting image page cannot be accessed
correctly through the wiki (ie for deletion or renaming).

Example:
Upload of image something like &quot;E with # blah blah.png&quot;
mismunged into 'E_with_'. The resulting name is
invalid: it ends with a space which gets trimmed off by
most other functions. And, of course, the remainder of
the filename is cropped instead of just the offending
character being blanked out, so is doubly wrong.

Seriousness:
Requires manual intervention to clean up the bad
entries from the tables. No serious data loss, as
original uploaded immediately recognizes that it did
not succeed and uploads under a new title.

------------------------- Additional comments ------------------------
Date: 2003-04-14 02:30
Sender: SF user vibber

Likely shares some issues with #695913 Bad titles not
properly filtered on page creation.
-------------------------------------------------
Date: 2004-08-09 23:41
Sender: SF user jeluf

Checked in a fix that addresses the #'s. Replaces them by
hyphens so that there are no problems with underscore-merging.

SpecialUpload.php, rev. 1.31

Any additional issues left?
Comment 1 admin 2006-11-14 01:42:35 UTC
Created attachment 2705 [details]
kawaser5.jpeg

kawaser5.jpeg

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links