Last modified: 2014-03-28 10:18:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36749, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34749 - [SMW] When mainlabel specified an extra mainlabel parameter is added in the further results link
[SMW] When mainlabel specified an extra mainlabel parameter is added in the f...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Jeroen De Dauw
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-27 03:48 UTC by badon
Modified: 2014-03-28 10:18 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description badon 2012-02-27 03:48:31 UTC
SMW 1.7.0.0.2 MW 1.18

This query:

{{#ask: [[Anything]] 
 | mainlabel=Anymainlabel 
}}

Will be changed to this query, when clicking on "further results":

{{#ask: [[Anything]] 
 | mainlabel=Anymainlabel 
 | ?=Anymainlabel#
}}

Notice that this part is added by the further results URL query string:

?=Anymainlabel#

The relevant further results url query string is:

/Special:Ask/-5B-5BAnything-5D-5D/-3F%3DAnymainlabel-23/mainlabel%3DAnymainlabel/

When it should be:

/Special:Ask/-5B-5BAnything-5D-5D/mainlabel%3DAnymainlabel/

Note that the query string is produced correctly if it starts out as it would otherwise be incorrectly done. This:

{{#ask: [[Anything]] 
 | mainlabel=Anymainlabel 
 | ?=Anymainlabel#
}}

Will produce this:

/Special:Ask/-5B-5BAnything-5D-5D/-3F%3DAnymainlabel-23/mainlabel%3DAnymainlabel/

Just like it should.

This bug is all that look similar when I searched prior to entering this bug. It might be somehow related:

https://bugzilla.wikimedia.org/show_bug.cgi?id=23722
Comment 1 badon 2012-03-03 23:54:40 UTC
I have just discovered that manually formatting a URL query string will not eliminate extra: 

?=Anymainlabel# 

That will still be displayed on the Special:Ask page, even if the URL does not contain it. So, the problem is deeper than just the "Further results" link.
Comment 2 Yaron Koren 2012-10-19 16:06:25 UTC
This problem also occurs for the export formats (CSV, DSV, JSON, possibly others). I'm assigning this to Jeroen.
Comment 3 djschaap 2013-03-15 15:28:03 UTC
I found explicitly hiding the first column via mainlabel=-, then including it in the first position via ?= seems to work around this.  When used with format=template, this keeps the numbered parameters correct, too.

{{#ask: [[Anything]] 
 | ?=Anymainlabel
 | ?more fields ...
 | mainlabel=-
}}
Comment 4 Jeroen De Dauw 2013-03-23 03:35:16 UTC
Is this still present in 1.8?
Comment 5 badon 2013-03-23 05:55:21 UTC
I have not upgraded to 1.8 yet. I've got to set aside some time to be able to find and fix anything that breaks after the upgrade is done. Rolling out fixes is time consuming on large wikis, so I've been updating a few mechanisms we have to make it easier to fix things that will inevitably get broken by something unexpected when we upgrade. I haven't stayed current on the mailing list, so I will have to review the traffic to get up to speed about likely trouble spots from the 1.7 to 1.8 upgrade. As far as I am aware, most of the changes were performance related, from NischayN's GSoC work, so maybe there's not much to worry about when upgrading.
Comment 6 tarkis13 2014-01-16 17:09:41 UTC
(In reply to comment #4)
> Is this still present in 1.8?

I can confirm that it is still present in 1.9.0.1.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links