Last modified: 2012-02-28 12:52:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36702, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34702 - Use localised parentheses in Special:Contributions, RecentChanges and ShortPages
Use localised parentheses in Special:Contributions, RecentChanges and ShortPages
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.19
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: i18n, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-25 06:23 UTC by Yusuke Matsubara
Modified: 2012-02-28 12:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
supplemental changes to replace parentheses literals with localised parentheses in Special:Contributions and Special:RecentChanges (5.70 KB, patch)
2012-02-28 05:46 UTC, Yusuke Matsubara
Details

Description Yusuke Matsubara 2012-02-25 06:23:18 UTC
Some instances of parentheses in Special:Contributions and others should be replaced with the localised version (when it exists).  The unlocalised ones sometimes don't produce the typographically ideal sequence of characters.

For example, '(差異 | 歷史)' '(diff | hist)' in Special:Contributions on mediawikiwiki does not use the localised parentheses when I specify Chinese [1][2].

Other examples:
* the day name such as (星期五), and the links after username (對話 | 貢獻) in RecentChanges [3]
* '(歷史)' in ShortPages‎ [4]


[1] https://www.mediawiki.org/wiki/Special:Contributions/Whym?uselang=zh-hant
[2] https://www.mediawiki.org/wiki/MediaWiki:Parentheses/zh-hant
[3] https://www.mediawiki.org/w/index.php?title=Special:RecentChanges&tagfilter=Added+PHP+closing+tag&uselang=zh-hant
[4] https://www.mediawiki.org/w/index.php?title=Special:ShortPages&uselang=zh-hant
Comment 1 Mark A. Hershberger 2012-02-25 17:59:48 UTC
> Some instances of parentheses in Special:Contributions and others should be
> replaced with the localised version (when it exists).

Could you give an example of how this should look and a link to some supporting documentation of this?
Comment 2 Siebrand Mazeland 2012-02-25 18:26:04 UTC
These lists should use pipe-separator and parentheses messages.
Comment 3 Siebrand Mazeland 2012-02-25 20:56:01 UTC
Fixed for Special:Contributions in r112410 and r112412.

If you feel like it, please give creating a patch to fix this in the other pages you mentioned a go.
Comment 4 Siebrand Mazeland 2012-02-26 13:12:50 UTC
With r112433 many more issues have been resolved. Please provide specific cases of this in core when reopening the bug.

I've also fixed an issue in Translate (Special:Translations), and found issues in SemanticMediaWiki that I haven't resolved.
Comment 5 Yusuke Matsubara 2012-02-28 05:46:35 UTC
Created attachment 10122 [details]
supplemental changes to replace parentheses literals with localised parentheses in  Special:Contributions and Special:RecentChanges

I noticed link items like '(talk|contribs)' in RecentChanges were still not i18nised.  Please review and apply the patch to i18nise those parentheses used in the RecentChanges and history pages.
Comment 6 Siebrand Mazeland 2012-02-28 11:58:34 UTC
(In reply to comment #5)
> Created attachment 10122 [details]

Very nice. Thank you! I've committed this, with very minor whitespace updates in r112589. I'll grep for the patters and will see if there's more low hanging fruit...
Comment 7 Siebrand Mazeland 2012-02-28 12:52:34 UTC
Made another commit for this: r112591. Kind of done with this now ;).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links