Last modified: 2014-07-22 01:11:26 UTC
Don't you think the HTML titles should mention that we are looking at a diff, not the page itself? Title: 台南市消防局 - 台掃 URL: http://radioscanningtw.jidanni.org/index.php?title=%E5%8F%B0%E5%8D%97%E5%B8%82%E6%B6%88%E9%98%B2%E5%B1%80 Title: 台南市消防局 - 台掃 URL: http://radioscanningtw.jidanni.org/index.php?title=%E5%8F%B0%E5%8D%97%E5%B8%82%E6%B6%88%E9%98%B2%E5%B1%80&diff=5528&oldid=5523 You do this for the history, why not the diff? Title: Revision history of "台南市消防局" - 台掃 URL: http://radioscanningtw.jidanni.org/index.php?title=%E5%8F%B0%E5%8D%97%E5%B8%82%E6%B6%88%E9%98%B2%E5%B1%80&curid=1413&action=history&uselang=en How are people supposed to differentiate these in their browser history? I didn't test to see the titles produced by any other of the buttons on the page, however I fear the worst.
Created attachment 10238 [details] Adds the required title Adding the new message I hope this helps.
I agree that this is a bug that should be fixed. I also didn't like that the title of the diff page is the same as of the page itself. Patch 10238 looks good to me functionally, but: * wfMessage() is better than wfMsg(), see https://www.mediawiki.org/wiki/New_messages_API * setPageTitle() would be better inside showDiffPage() * Documentation for the new message must be added in MessagesQqq.php. Please mention that it's the title of the HTML page. * Please consider adding the message to MessagesAs.php, too :)
Created attachment 10302 [details] added msg documentation
(In reply to comment #2) > * wfMessage() is better than wfMsg(), see > * setPageTitle() would be better inside showDiffPage() > * Documentation for the new message must be added in MessagesQqq.php. Please > mention that it's the title of the HTML page. Did the changes you suggested > * Please consider adding the message to MessagesAs.php, too :) I think I don't have language support in my system right now, also I won't be good at the job I suppose
The patch looks good (except unnecessary whitespace on line 682). I'll apply it after the Git migration.
Applied in https://gerrit.wikimedia.org/r/#change,3361 (i hope).
Merged.
Thanks, Nischay!
This fix was improved on change I4803be2265b1209929ae5ba6d08c2371b0f7d759 but that improvement was reverted on change Iad2c25fbbb673ad95781b29630193bc9de97b1be.
