Last modified: 2011-03-13 18:06:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5335, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3335 - The Action Buttons are Hidden from View in Smaller Browsers
The Action Buttons are Hidden from View in Smaller Browsers
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://*.wikipedia.org/w/index.php?ti...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-09-02 13:16 UTC by Dave Babbitt
Modified: 2011-03-13 18:06 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
This is the way I added the enhancement on my private copy of WikiMedia. (28.77 KB, text/plain)
2005-09-02 13:21 UTC, Dave Babbitt
Details

Description Dave Babbitt 2005-09-02 13:16:00 UTC
When initally editing a section or page, the text area and "Save page" and "Show
preview" buttons are what the user is focusing on. It would be nice if the page
automatically scrolled the buttons into view.

After the wpPreview submit button is addHTMLed in /includes/EditPage.php (line
548?), it would be nice if this code was added:

		if ( 'preview' != $formtype) {
			$wgOut->addHTML( "<script type='text/javascript'>
	/* Try to scroll the wpPreview button into view */
	if(document.getElementById) {var target = document.getElementById('wpPreview');}
	else {var target = document.all.wpPreview;}
	if(window.showModalDialog && window.clipboardData && window.createPopup) {
		window.scroll(0,0);
		var range = target.createTextRange();
		range.scrollIntoView();
		window.scrollBy(0,6);
		}
	else {
		var buttonOffset = target.offsetTop + target.offsetParent.offsetTop;
		var buttonScroll = document.body.scrollTop;
		if((buttonOffset + target.clientHeight) > (buttonScroll +
document.body.clientHeight)) {
			target.scrollIntoView(false);
			}
		else if(buttonOffset < buttonScroll) {target.scrollIntoView(true);}
		}
</script>" );
Comment 1 Dave Babbitt 2005-09-02 13:21:08 UTC
Created attachment 848 [details]
This is the way I added the enhancement on my private copy of WikiMedia.
Comment 2 Brion Vibber 2006-02-03 06:39:28 UTC
This would be generally confusing, and likely to obscure titles, messages, etc.
Causing things to jump about unexpectedly is rarely a good idea.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links