Last modified: 2008-11-03 12:02:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3318 - License selector: <option disabled="disabled"> doesn't work in some browsers
License selector: <option disabled="disabled"> doesn't work in some browsers
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.6.x
PC All
: Normal normal with 10 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
:
: 3333 4313 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-30 19:55 UTC by JePe
Modified: 2008-11-03 12:02 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description JePe 2005-08-30 19:55:44 UTC
With the new licensing selection menu in special:upload the description above a group 
of licenses is rendered in html with <option disabled>. In Firefox this menu-option 
is grayed out and not selectable. However in Internet Explorer this menu-option is 
displayed normal in black and can be selected just as the other options.

An other possibility what works normal in IE is to use <optgroup> to display a 
description for a group of menu-items.

Something else, can it be made possible to assign also a template to the "none" 
option if there is no licence selected.
Comment 1 Ævar Arnfjörð Bjarmason 2005-08-30 20:01:12 UTC
Well it's not really our problem if Internet Explorer doesn't adhere to the
XHTML specification, but how could the <optgroup> element be used to provide a
workaround?
Comment 2 JePe 2005-08-30 20:20:20 UTC
You have however only one indent level and it can be used in the folowing way:
<optgroup label="GNU licenses">
<option ...>
<option ...>
</optgroup>

Firefox is a better browser but the reality is that Internet Explorer is the 
most used browser.
Comment 3 Brion Vibber 2005-08-30 23:25:49 UTC
Quick survey of <option disabled="disabled"> on Special:Upload

* IE 6.0 on XPSP2: ignored
* Safari 2.0.1: ignored
* IE 5.2/Mac (OS X): disabled works, but the indented entries don't show in the pop-up
* IE 5.0/Mac (Classic): works
* Firefox 1.0.6: works
* Opera 8.02: works
Comment 4 Brion Vibber 2005-09-02 09:44:26 UTC
*** Bug 3333 has been marked as a duplicate of this bug. ***
Comment 5 Christian Thiele 2005-09-02 11:57:11 UTC
* IE 7 Beta 1 on XPSP2: ignored
Comment 6 ejsanders 2005-09-09 22:45:27 UTC
Yup, another bug in IE, hooray. But seeing as nested groups aren't really
required here, the <optgroup> tag would be the best solution. Note that "all
OPTGROUP elements must be specified directly within a SELECT element (i.e.,
groups may not be nested).", but they do auto indent the groups and emphasise
the labels (in IE as well).
Comment 7 Ævar Arnfjörð Bjarmason 2005-09-09 22:53:31 UTC
(In reply to comment #6)
> But seeing as nested groups aren't really required here

But more useful than not having them.
Comment 8 ejsanders 2005-09-10 12:05:01 UTC
I don't know if it's intentional, but the nested groups don't do anything at the
moment. Everything is just indented by one level, which is acceptable.
Comment 9 JePe 2005-09-10 12:56:13 UTC
I think, a lot of nested groups which are also selectable by the most users, 
are very confusing for especially new users. So, a lot of uploads on the Dutch 
Wikipedia since there is the license-selector haven't the just license or no 
license at all. 

It must be impossible to upload a file without selecting a license, also 
the 'none selected' option should not be selectable or there must be a template 
like {{Unknown}} assigned to.
Comment 10 Brion Vibber 2005-09-10 22:39:36 UTC
This is offtopic for this bug, but to reply to the previous comment: we quite 
deliberately *do not* block uploads with the no license option, since the 
most likely alternative is a lot of absolutely totally 100% non-free material 
getting uploaded with false license information because people just click 
whatever lets it go through. Then it's harder to track down and delete them.

To suggest alternative behavior, please open a new bug rather than commenting 
further here.
Comment 11 Brion Vibber 2005-12-19 20:50:27 UTC
*** Bug 4313 has been marked as a duplicate of this bug. ***
Comment 12 Brion Vibber 2006-01-01 01:09:42 UTC
I've added a CSS style which makes the disabled items show grayed-out correctly in MSIE/Windows.

Additionally, a JavaScript hack will revert the selector to "None selected" if you actually select one of the disabled items. 
There might be further improvements which can be made here.

Safari still doesn't show the disabled items as gray, but the hack to prevent them from being selected is there, and 
should be at least a bit of a cue to users that their selection didn't take.

Another JavaScript hack seems to fix the display problem in MSIE/Mac. (Setting the option text to itself... oh what a 
lovely bug!)

Comment 13 Brion Vibber 2006-06-03 23:36:45 UTC
I guess this should have been set to FIXED?

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links