Last modified: 2012-05-03 02:42:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35167, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33167 - Log entries broken due to LogPage::actionText() calls to logs with $wgLogActionHandler function callbacks
Log entries broken due to LogPage::actionText() calls to logs with $wgLogActi...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.20.x
All All
: High normal (vote)
: 1.19.0 release
Assigned To: Niklas Laxström
:
Depends on:
Blocks: 31217
  Show dependency tree / graph
 
Reported: 2011-12-15 12:20 UTC by Jarry1250
Modified: 2012-05-03 02:42 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Jarry1250 2011-12-15 12:20:45 UTC 
Various (all?) revision deletion combinations involving the "Suppress data from administrators as well as others" option yield the following error:

<b>Warning</b>:  call_user_func_array() expects parameter 1 to be a valid callback, function 'DeleteLogFormatter' not found or invalid function name in <b>C:\xampp\htdocs\w\includes\logging\LogPage.php</b> on line <b>296</b>
Comment 1 Mark A. Hershberger 2012-01-25 17:47:03 UTC 
It'd be good to test this on enwiki.beta
Comment 2 Mark A. Hershberger 2012-02-02 21:56:06 UTC 
Niklas, could you look at this 1.19 blocker?
Comment 3 Rob Lanphier 2012-02-03 19:44:05 UTC 
Spoke with Aaron; he's going to comment on this further.  There's more information in code review about this issue.  Basically, this is more about logging generally than it is about RevDel
Comment 4 Aaron Schulz 2012-02-03 19:47:24 UTC 
See r96546 CR comments. This doesn't effect regular (non-suppress) revision deletion because the $wgLogActionHandlers wildcards aren't checked in LogPage::actionText().
Comment 5 Niklas Laxström 2012-02-04 04:27:37 UTC 
Just to let you know, I'm very busy during FOSDEM and few days after.
Comment 6 Sumana Harihareswara 2012-02-06 22:31:20 UTC 
Per conversation with RobLa, reassigning to Niklas.
Comment 7 Aaron Schulz 2012-02-08 19:55:50 UTC 
Fixed in r110953.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links