Last modified: 2006-05-05 12:19:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3309 - Undeletion should allow for an edit summary
Undeletion should allow for an edit summary
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal enhancement with 3 votes (vote)
: ---
Assigned To: Rob Church
http://en.wikipedia.org/wiki/Special:...
: patch, patch-reviewed
: 3372 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-30 17:53 UTC by p_simoons
Modified: 2006-05-05 12:19 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch from Phroziac over on the other bug; uploading here in appropriate format (638 bytes, patch)
2005-12-18 23:13 UTC, Rob Church
Details
Patch from Phroziac over on the other bug; uploading here in appropriate format (part two) (2.16 KB, patch)
2005-12-18 23:14 UTC, Rob Church
Details

Description p_simoons 2005-08-30 17:53:58 UTC
Since undeletion is basically undoing another admin's action, it would be nice
if it were possible to enter an edit summary when undeleting anything. This
would then show up in the deletion log, along with the edit summaries for
deleting things. E.g. "history undeletion", or "VFU consensus" or "misreading of
CSD#G3".

Presently admins tend to perform a null edit after undeletion in order to
present their reasoning, if they want. But those don't appear in the deletion
log, of course.
Comment 1 Stephanie Amanda Stevens 2005-09-06 17:20:52 UTC
*** Bug 3372 has been marked as a duplicate of this bug. ***
Comment 2 Rob Church 2005-12-18 23:13:32 UTC
Created attachment 1209 [details]
Patch from Phroziac over on the other bug; uploading here in appropriate format
Comment 3 Rob Church 2005-12-18 23:14:03 UTC
Created attachment 1210 [details]
Patch from Phroziac over on the other bug; uploading here in appropriate format (part two)
Comment 4 Brion Vibber 2005-12-19 22:21:37 UTC
This patch mixes UI code into the backend; needs a little work.

The UndeleteForm class should be checking the request for variables, and then pass the 
reason if given on to the backend class PageArchive. PageArchive could be used in a 
batch operation or other specialized case, so you should not assume that $wgRequest 
will belong to an UndeleteForm in the other class.

It would probably be good also to be consistent about the form field naming; this form 
seems to be using mostly plain names, so 'reason' might be better than 'mReason'.
Comment 5 Rob Church 2006-05-05 12:19:52 UTC
Added in SVN trunk, r14090.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links