Last modified: 2013-11-16 18:41:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T35029, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 33029 - Special:LinkSearch does not display results for links containing colon
Special:LinkSearch does not display results for links containing colon
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.18.x
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-13 14:09 UTC by Danny B.
Modified: 2013-11-16 18:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Danny B. 2011-12-13 14:09:44 UTC 
Special:LinkSearch does not display results for links containing colon

Compare:

https://cs.wikipedia.org/wiki/Special:LinkSearch/commons.wikimedia.org/wiki/Category

and

https://cs.wikipedia.org/wiki/Special:LinkSearch/commons.wikimedia.org/wiki/Category:


I did not try any other not alphanum chars, but I would assume, that the issue might be in not consistent urlencoding / nourlencoding between the form value and the value stored in database.
Comment 1 Elliott Eggleston 2013-09-17 00:52:19 UTC 
Looks like it's actually colon-specific.  LinkSearch is assuming anything before the colon is a protocol (URI scheme).  If there is no colon it defaults to 'http://', but with an unrecognizable protocol it defaults to the empty string.
Comment 2 Elliott Eggleston 2013-09-17 00:56:10 UTC 
Submitted patch: https://gerrit.wikimedia.org/r/84475
Comment 3 Andre Klapper 2013-09-17 12:14:43 UTC 
Thanks Elliott! (For future reference: Writing "Bug: 33029" instead of "Bug:33029" will create an automatic notification in this bug report.)
Comment 4 Gerrit Notification Bot 2013-09-20 02:09:18 UTC 
Change 84475 had a related patch set uploaded by Ejegg:
LinkSearch: use default protocol if unsupported

https://gerrit.wikimedia.org/r/84475
Comment 5 Gerrit Notification Bot 2013-11-16 18:35:58 UTC 
Change 84475 merged by jenkins-bot:
LinkSearch: use default protocol if unsupported

https://gerrit.wikimedia.org/r/84475
Comment 6 Bawolff (Brian Wolff) 2013-11-16 18:41:17 UTC 
Thank you for your patch :)
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links