Last modified: 2010-05-15 15:38:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5293, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3293 - Inconsistent (double) textstring Special:Confirmemail and Special:Preferences
Inconsistent (double) textstring Special:Confirmemail and Special:Preferences
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-28 18:13 UTC by T. Gries
Modified: 2010-05-15 15:38 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2005-08-28 18:13:34 UTC
In SpecialPreferences lines 287-289, currently text strings 

- mailerror, $1 and 
- eauthentsent, $1

are used; they have an additional $1 part. These parts are used, when a user
changes the stored e-mail address and the wiki automatically sends out the
confirmation e-mail.

In SpecialConfirmemail lines 55-57 a similar construct is used, when the user
explicitly requests e-mail confirmation. You can see the very similar code
construction. But they used strings are here 

- confirmemail_sendfailed and 
- confirmemail_sent

Due to a different program structure, wfMsg is not used here.

The target of this bugzilla is to show that an improved code (of text handling
in Confirmemail.php) could save two of the four text strings, becauses they have
essentially the same meaning.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links