Last modified: 2010-05-15 14:36:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T5284, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 3284 - Block list is very slow
Block list is very slow
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Brion Vibber
http://en.wikipedia.org/wiki/Special:...
:
: 3314 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-27 18:26 UTC by Robert Rohde
Modified: 2010-05-15 14:36 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Robert Rohde 2005-08-27 18:26:37 UTC
There are presently 4744 active blocks on Wikipedia EN:

http://en.wikipedia.org/wiki/Special:Ipblocklist

On a good day this makes the block list very slow to load.  If the servers are 
already overloaded, it is basically unusuable.

I think this is because SpecialIpblocklist::wfAddRow calls User::whoIs for each 
entry in order to identify the name of the blocking admin on each block.  That 
means that to load the block list it is presently necessary to make more than 
4744 distinct database queries.  I would suggest that either Block::enumBlocks be 
modified to join on the list of blocking admin usernames, or that the blocklist 
be reformated into pages the same way most other query pages are so it only loads 
a fraction of the blocks at any one time.

With the continuing war with the Willy on Wheels vandal (see: [[1454]]), the 
block list is only likely to grow and make the problem worse.

-DF
Comment 1 Brion Vibber 2005-08-27 20:38:34 UTC
Block::enumBlocks already does join to user to get the 
username of the blocking user; I think Tim made this change 
earlier this week.
Comment 2 Brion Vibber 2005-08-27 21:08:14 UTC
It's still hella slow though; I got times of about 11 and 
14 seconds for page rendering (and then the list has to 
download and render in the browser, which is pretty slow 
-- the uncompressed HTML comes out to 2.4 megabytes!)

This is about 2-3 milliseconds of rendering and 500 bytes 
of HTML per block.

Either paging or slimming down the output would be good, 
perhaps both. Taking bug.
Comment 3 Brion Vibber 2005-08-27 23:58:19 UTC
There's not much output to slim without removing links or data, which would make it 
harder to use.

I've added basic paging and a substring match so you can easily look for a block by 
username or IP (or subtring thereof):
http://en.wikipedia.org/w/index.php?
title=Special:Ipblocklist&limit=250&offset=0&ip=willy

Changes:
http://mail.wikipedia.org/pipermail/mediawiki-cvs/2005-August/010944.html
Comment 4 Robert Rohde 2005-08-28 03:04:59 UTC
Thanks alot.
Comment 5 Brion Vibber 2005-08-30 22:23:44 UTC
*** Bug 3314 has been marked as a duplicate of this bug. ***
Comment 6 p_simoons 2005-09-01 07:58:46 UTC
(copied from 3314)

Ipblocklist is too long, in particular because of the excessive amount of
perma-blocked vandal accounts. If an account is permablocked for a long time, it
would be easier to unblock it and scramble the password.

Alternatively, give the Ipblocklist a pulldown menu to only show
non-permablocks, or only blocks made the last month, etc.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links