Last modified: 2013-12-02 16:26:38 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34744, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 32744 - Xml:dateMenu() return wrong year when current month is december
Xml:dateMenu() return wrong year when current month is december
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-12-01 00:45 UTC by Sam Reed (reedy)
Modified: 2013-12-02 16:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-12-01 00:45:20 UTC 
Seems now it's December in UTC, the tests broke, great, huh?

Commented out in r104812
Comment 1 Antoine "hashar" Musso (WMF) 2011-12-01 12:45:54 UTC 
When calling Xml::dateMenu() function with no year and a month (ex: Xml::dateMenu( '', 01)The behavior is a bit strange.

Calling:

Xml:dateMenu( '', 01) in December 2011 returns: December 2011

Xml:dateMenu( '', 02) in January 2012 returns: February 2011

I am sure the idea is to not return a date in the future when year is unspecified. So the first call above should returns December 2010, not 2011.

Hence the tests are fine and Xml::dateMenu() need fixing.
Comment 2 Brion Vibber 2011-12-12 04:17:43 UTC 
What's that function *meant* to do? Its doc comment says nothing about passing empty strings in the year/month params...
Comment 3 Andre Klapper 2013-07-03 12:31:00 UTC 
Anybody knows what Xml::dateMenu() is supposed to actually do? See comment 2.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links