Last modified: 2012-02-23 01:48:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T34512, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 32512 - Add 'Associated namespace' checkbox to Special:Contributions


Summary:	Add 'Associated namespace' checkbox to Special:Contributions

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal enhancement (vote)
Target Milestone:	1.19.0 release
Assigned To:	Brion Vibber

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-11-20 04:06 UTC by Srikanth Logic
Modified:	2012-02-23 01:48 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patch against trunk (3.63 KB, patch) 2011-12-05 00:33 UTC, MrBlueSky	Details
Screenshot of form kinda spilling over in an ugly way (37.36 KB, image/png) 2011-12-13 23:15 UTC, Brion Vibber	Details
Patch against trunk (8.96 KB, patch) 2011-12-15 00:38 UTC, MrBlueSky	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Srikanth Logic 2011-11-20 04:06:56 UTC

Provide the option to filter by "Associated namespace" on the Special:Contributions/{{User}} page like Special:RecentChanges page.

Comment 1 MrBlueSky 2011-12-05 00:33:09 UTC

Created attachment 9612 [details]
Patch against trunk

Comment 2 Brion Vibber 2011-12-13 23:15:50 UTC

Created attachment 9680 [details]
Screenshot of form kinda spilling over in an ugly way

Looks good overall... A couple things:

Notice: Use of MWNamespace::isMain was deprecated in MediaWiki 1.19. [Called from MWNamespace::getAssociated in /var/www/trunk/includes/Namespace.php at line 129] in /var/www/trunk/includes/GlobalFunctions.php on line 3520

switching to isSubject will resolve that.

It's also kinda cluttering up the screen. Attaching a screenshot -- the checkbox may end up splitting over a linebreak and in general it looks like this needs some improvement to group the namespace together with the namespace-related options.

Fix those and I'm happy to land this!

Comment 3 MrBlueSky 2011-12-15 00:38:13 UTC

Created attachment 9705 [details]
Patch against trunk

The notice came from MWNamespace::getAssociated(), which still used isMain().

I've made the grouping of the form friendlier for small window sizes, and I also put it in a table and split the code into some chunks so that its easier to move parts of the form around when needed.

Comment 4 Brion Vibber 2011-12-15 01:02:40 UTC

Looks good! I've applied to trunk (for 1.19) in r106297.

Comment 5 Antoine "hashar" Musso (WMF) 2011-12-18 15:48:32 UTC

Thanks for porting this from RecentChanges to Contribs :)

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links