Last modified: 2005-08-22 01:38:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3210 - Media: links don't work; use http-noparse protocol
Media: links don't work; use http-noparse protocol
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.6.x
All All
: Normal critical with 5 votes (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-20 17:41 UTC by David Benbennick
Modified: 2005-08-22 01:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Fix; checked in on Linker.php revision 1.48 (620 bytes, patch)
2005-08-21 00:43 UTC, Brion Vibber
Details

Description David Benbennick 2005-08-20 17:41:18 UTC
Links such as [[Media:Wiki.png]] no longer work in 1.6alpha.  The 
produced link is 
 
http-noparse://upload.wikimedia.org/wikipedia/en/b/bc/Wiki.png 
 
Every browser I've tried (Konqueror and Firefox) complains that this is 
an unknown protocol.
Comment 1 bdk 2005-08-20 20:52:13 UTC
See http://en.wikipedia.org/wiki/Bach for example, many links in the main namespace are broken.
Comment 2 bdk 2005-08-20 21:00:01 UTC
... forgot to point at the exact section where you can try all the broken media links: http://en.wikipedia.org/wiki/Bach#Media 

Comment 3 Brion Vibber 2005-08-21 00:21:54 UTC
Seems to affect all media: links when $wgUploadPath is non-local.
Comment 4 Brion Vibber 2005-08-21 00:30:46 UTC
Bug was introduced within last couple of days on REL1_5 and HEAD.
Comment 5 Brion Vibber 2005-08-21 00:43:45 UTC
Created attachment 821 [details]
Fix; checked in on Linker.php revision 1.48

Fixed on REL1_5 and HEAD. Someone changed how noparse links work without
updating all uses of it.

r1=1.47&r2=1.48">http://cvs.defau.lt/cvsweb.cgi/phase3/includes/Linker.php.diff?r1=1.47&r2=1.48
Comment 6 Rowan Collins [IMSoP] 2005-08-22 01:38:00 UTC
(In reply to comment #5)
> Fixed on REL1_5 and HEAD. Someone changed how noparse links work without
> updating all uses of it.

Sorry, my bad (fixing bug 3090) - didn't think to "grep -r" so only changed one
file :/
Should probably turn it into a pair of functions somewhere, to avoid such
problems (presumably there's a potential for the media: link to begin https://
not http:// and therefore break for the same reason as bug 3090...)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links