Last modified: 2012-08-15 10:20:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3162 - Undefined variables $y (SpecialWatchlist) and property page_is_new (RecentChange) in REL1_5
Undefined variables $y (SpecialWatchlist) and property page_is_new (RecentCha...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Highest major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 1002
  Show dependency treegraph
 
Reported: 2005-08-15 22:58 UTC by T. Gries
Modified: 2012-08-15 10:20 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description T. Gries 2005-08-15 22:58:46 UTC
Someone has reported to me the following problems

*  When accessing my watchlist page the following notice is displayed: 

Notice: Undefined variable: y in d:\easyphp\www\includes\SpecialWatchlist.php on
line 217

and after it the following two notices are shown once for each page I have
configured to watch in my user profile:

Notice: Undefined property: page_is_new in
d:\easyphp\www\includes\RecentChange.php on line 383

Notice: Undefined property: page_is_new in
d:\easyphp\www\includes\RecentChange.php on line 393
Comment 1 Niklas Laxström 2005-08-16 13:24:21 UTC
Fixed the first one, don't know about latter
Comment 2 T. Gries 2005-08-16 19:21:29 UTC
(In reply to comment #1)
> Fixed the first one, don't know about latter

Niklas:
Where have you fixed that ?
I cannot see an attachment, and als http://cvs.defau.lt hasn't your patch.
Comment 3 T. Gries 2005-08-16 20:59:04 UTC
1st bug PATCH 
In SpecialWatchlist.php change lines 215 ff 
 
FROM 
	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems ), 
###	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems / 2 ), 
		$wgLang->formatNum( $npages ), $y, 
		$specialTitle->getFullUrl( 'edit=yes' )); 
	$wgOut->addWikiText( $header ); 
 
TO 
	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems ) ); 
###	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems / 2 ), 
	$wgOut->addWikiText( $header ); 
 
Comment 4 T. Gries 2005-08-16 21:06:52 UTC
(In reply to comment #3)
> 1st bug PATCH 
> In SpecialWatchlist.php change lines 215 ff 
>  
> FROM 
> 	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems ), 
> ###	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems / 2 ), 
> 		$wgLang->formatNum( $npages ), $y, 
> 		$specialTitle->getFullUrl( 'edit=yes' )); 
> 	$wgOut->addWikiText( $header ); 
>  
> TO 
> 	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems ) ); 
> ###	$header .= wfMsg( 'watchdetails', $wgLang->formatNum( $nitems / 2 ), 
> 	$wgOut->addWikiText( $header ); 
>  
I am not fully sure about these old lines. Needs review.

Comment 5 T. Gries 2005-08-17 07:13:40 UTC
I dare about rising priority even higher, but these problems need to be fixed soon.

The first problem is related to the _old_ page header on watchlist. I have no
idea, if the two lines can be deleted (what I suggest) , or if someone of the
developers want to keep them there.

The second problem -- $row->page_is_new undefined properity in RecentChange.php
-- alerted me now after having studied the code in Article.php and
RecentChange.php . The "undefined property" could be related to an overlooked or
forgotten fix due to recent schema change. Remark: the reporter of the bug (not
me) runs Easyphp, which might be not so relucant to undefined stuff as PHP is
sometimes.
Comment 6 Brion Vibber 2005-08-17 08:54:24 UTC
Somebody wrote rev_is_new instead of page_is_new.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links