Last modified: 2012-02-24 02:52:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33449, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31449 - Canon EOS-1D Article has extra width on Android app
Canon EOS-1D Article has extra width on Android app
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Highest blocker
: ---
Assigned To: Yohei Shimomae
:
Depends on:
Blocks: 31447
  Show dependency treegraph
 
Reported: 2011-10-07 00:15 UTC by Tomasz Finc
Modified: 2012-02-24 02:52 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz Finc 2011-10-07 00:15:11 UTC
Load the article and you'll notice that it allows you to scroll left and right even though we have no content there. This doesn't happen on our own mobile gateway. Same issue on the "San Francisco" article.

First filed at: https://github.com/nitobi/Wikipedia/issues/8
Comment 1 Brion Vibber 2011-10-07 22:07:06 UTC
I couldn't repro this on 'San Francisco' but did see a _couple pixels_ of scroll area on 'Canon EOS-1D'.

Opening the lower sections of that Canon page did show a big giant table squooshing a bunch of stuff together, though, which made it scroll a little more.
Comment 2 Brion Vibber 2011-10-07 22:09:55 UTC
(tested on Nexus 1, android 2.3.6)
Comment 3 al.harding 2011-10-12 22:51:30 UTC
Yohei, can you look into this and see what solutions we can come up with.
Comment 4 Yohei Shimomae 2011-10-17 20:54:06 UTC
So the quickest and clean way to solve this right now is to add the next lines of CSS to wikipedia mobile site (this needs to be done from the actual wiki site and not the app as trying to do this from the app will run into crossdomain error):

img {
    height: auto;
    max-width: 100%;
}

This will prevent all the images from going beyond device width. Please note that this applies to all images on the site while this additional CSS is in place. So this also affects to image detail page (e.g. http://en.m.wikipedia.org/wiki/File:Canon_EOS-1D.jpg) but not the link to the actual image (e.g. http://upload.wikimedia.org/wikipedia/commons/a/a4/Canon_EOS-1D.jpg).

This styling won't affect tables and non-image elements.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links