Last modified: 2011-10-24 19:56:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33441, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31441 - allow sysops to add/remove new user group "autoreview"
allow sysops to add/remove new user group "autoreview"
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 3 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-06 19:16 UTC by Umherirrender
Modified: 2011-10-24 19:56 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Umherirrender 2011-10-06 19:16:22 UTC 
Since MediaWiki 1.18 the user group "autoreview" (FlaggedRevs) is not implicit and therefor can be add/removed from a user.

Please allow sysops on wikis with this user group to add and/or remove this user group.

Thanks.
Comment 1 Umherirrender 2011-10-14 19:59:45 UTC 
Why is there no action since one week?

The new feature (bug 29655) is useless, when sysops have no permission to remove the group.
Comment 2 Mark A. Hershberger 2011-10-15 22:03:35 UTC 
tagging bugs for Marcus to look at
Comment 3 Matthias Becker 2011-10-17 15:50:06 UTC 
It was reported that also bureaucrates cannot remove users from this user group.
Comment 4 Sam Reed (reedy) 2011-10-20 04:04:24 UTC 
This isn't a shell bug

It needs fixing in FR (seemingly a regression), commiting, then pushing to site

Moving to FR
Comment 5 Aaron Schulz 2011-10-20 04:16:05 UTC 
(In reply to comment #4)
> This isn't a shell bug
> 
> It needs fixing in FR (seemingly a regression), commiting, then pushing to site
> 
> Moving to FR

It's not a regression. It was never removable. Now it is. It just needs to have addGroups/removeGroups set.
Comment 6 Sam Reed (reedy) 2011-10-20 04:18:15 UTC 
Was worth the clarification

Umherirrender, does this want doing everywhere that has FR enabled then?
Comment 7 Aaron Schulz 2011-10-20 04:22:34 UTC 
One option is to just have the extension itself let sysops add/remove the group by default. Since it already does this for 'editors' (which have more rights that 'review'), that might be the most logical approach.
Comment 8 Sam Reed (reedy) 2011-10-20 04:27:39 UTC 
(In reply to comment #7)
> One option is to just have the extension itself let sysops add/remove the group
> by default. Since it already does this for 'editors' (which have more rights
> that 'review'), that might be the most logical approach.

Seems sensible/saner TBH
Comment 9 Aaron Schulz 2011-10-20 05:13:00 UTC 
Added as software default in r100327.
Comment 10 Umherirrender 2011-10-20 15:15:24 UTC 
I have create a shell bug, because I do not know, if this should be part of the extension.

I am requesting the rights only for WMF wikis.

Please tag that rev for 1.18 and moving this bug to FlaggedRevs component or fix this bug by changing the config settings on wmf wikis. Thanks.
Comment 11 Umherirrender 2011-10-24 19:35:40 UTC 
Merged with r100635 to wmf wikis, fixed now. Thanks.
Comment 12 Sam Reed (reedy) 2011-10-24 19:56:23 UTC 
Merged and pushed to site

Moving back to be a FR bug
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links