Last modified: 2011-10-22 19:09:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33414, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31414 - Skin specific gadgets
Skin specific gadgets
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-06 07:17 UTC by Eran Roz
Modified: 2011-10-22 19:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Eran Roz 2011-10-06 07:17:00 UTC
Many gadgets today work or are intended to work only in some specific skins. It can be because the gadget "fixs" some issue in a specific skin, or because it is legacy gadget working only in some specific skins. (As you can see in [[:en:Special:Preferences#mw-prefsection-gadgets]] by searching "monobook" or "vector" there are already many scripts that work only in some skins).

Currently it is possible to mention specific rights needed for the user in gadgets-defintion in the format of:
gadget[rights=...]

I would like to request the same for skin - to declare for a gadget that works only in one or more skins.

This can be achieved easily by adding a small if in Gadget::isAllowed + another case in Gadget::newFromDefinition.
Comment 1 Liangent 2011-10-22 04:42:14 UTC
There's one difficulty: if a user has changed skin pref in Special:Preferences, then proceed to gadget prefs without saving skin pref first, gadgets for the new skin cannot be shown...
Comment 2 Eran Roz 2011-10-22 08:55:15 UTC
I didn't think about that, but with no special handling, it would behave the same as quickbar option in skin selection:  
When selecting cologneblue or standard skin, only after saving the new skin, a new option for selecting the position of the quick bar is displayed.
Comment 3 Liangent 2011-10-22 19:09:43 UTC
r100509

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links