Last modified: 2012-09-19 18:13:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33191, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 31191 - "Not logged in" p-personal javascript should not be triggered after login


Summary:	"Not logged in" p-personal javascript should not be triggered after login

Status:	VERIFIED FIXED

Product:	Wikimedia
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Duplicates:	31192 (view as bug list)
Depends on:
Blocks:	29068
	Show dependency tree / graph

Reported:	2011-09-27 18:07 UTC by Romaine
Modified:	2012-09-19 18:13 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Romaine 2011-09-27 18:07:24 UTC

When I am not logged in it shows (in Dutch): Niet aangemeld    Overlegpagina IP-adres    Bijdragen IP-adres

When I am logged in it shows: Romaine    Overleg    Voorkeuren    Volglijst    Bijdragen    Afmelden

But the first page I see when I log in is: Romaine    Overleg    Voorkeuren    Volglijst    Bijdragen    Afmelden    Niet aangemeld    Overlegpagina IP-adres    Bijdragen IP-adres

And that last one isn't correct, it shows the top two lines together.

Greetings - Romaine

Comment 1 Romaine 2011-09-27 18:08:09 UTC

Example: http://i56.tinypic.com/2cfuk2e.png

Comment 2 Krinkle 2011-09-27 18:49:56 UTC

This is created by the loggedOutTalkPage() function in nl.wikipedia's MediaWiki:Common.js.

Due to bug 31192, the javascript is also run on the first page when logging in. Because of the way that javascript function works, some links are left and thus both show up.

Once bug 31192 is fixed this will automatically be fixed.

Comment 3 Roan Kattouw 2011-09-27 19:16:50 UTC

*** Bug 31192 has been marked as a duplicate of this bug. ***

Comment 4 Roan Kattouw 2011-09-27 19:17:29 UTC

It's not a JS thing. The entire interface is slowing as logged out in my tests on localhost.

Comment 5 Roan Kattouw 2011-09-27 19:23:08 UTC

Fixed in r98237, deploying.

Comment 6 Roan Kattouw 2011-09-27 19:32:47 UTC

Fix deployed, should be working again now.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links