Last modified: 2005-08-12 04:31:16 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3119 - apply html-tidy only once
apply html-tidy only once
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.6.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://commons.wikimedia.org/wiki/Ima...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-11 18:54 UTC by Daniel Kinzler
Modified: 2005-08-12 04:31 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2005-08-11 18:54:11 UTC
right now, tidy is invoked when inserting wiki-formated messages too, by
OutputPage::addWikiText. This is not only redundant, but it also causes problems
when inserting short-messages inline: Tidy expects a block-element as the root,
it will insert <p> tags if no top-level block-element is present. This causes
such messages to be displayed in a new paragraph, like the file size/mime type
message in the example URL I provided. This is also the cause of bug #1337.

Applying tidy only once, to the full page, just before it is returned to the
client, would be much cleaner, avoid problems and save CPU cycles.
Comment 1 Daniel Kinzler 2005-08-11 18:56:48 UTC
Opps, the other bug caused by this is #3117. Sorry about this l33t mistake...

(bugzilla feature request: preview button for bug reports)
Comment 2 Brion Vibber 2005-08-12 04:23:13 UTC
Tidy is used to supplement our currently broken HTML normalization
code as a late step in wikitext parsing. As part of parsing, it by
definition can only be used within a given parsed wiki text block.

Note that wiki text blocks are supposed to be self-sufficient block
sections, so adding <p> tags if there was no block element is in fact
desired behavior.

If someone's trying to use multiple blocks on one line, that's a bug
and should be corrected.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links