Last modified: 2011-11-09 19:44:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33171, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 31171 - Using '#' as a token identifier in RapidHTML has severe CSS and JS implications
Using '#' as a token identifier in RapidHTML has severe CSS and JS implications
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
DonationInterface (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-26 20:53 UTC by Peter Gehres
Modified: 2011-11-09 19:44 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Peter Gehres 2011-09-26 20:53:30 UTC
The RapidHTML tokens starting with '#' clobber ID selection with the token name.

e.g.  The #amount token clobbers the following CSS and jQuery commands:
#amountTable { /* ... */ }
$("#amountTable")

Proposed fix, find a new token identifier that does not clash with PHP/HTML/CSS/JS or find another way to to the str_replace
Comment 1 Peter Gehres 2011-11-09 19:44:05 UTC
Resolved in r97776 by switching tokens from # to @

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97776

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links