Last modified: 2011-04-06 22:42:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 3086 - Make Special:Recentchanges enhancedchanges images more skinnable
Make Special:Recentchanges enhancedchanges images more skinnable
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Recent changes (Other open bugs)
1.18.x
All All
: Low enhancement with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-08-09 15:43 UTC by John Owens
Modified: 2011-04-06 22:42 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description John Owens 2005-08-09 15:43:27 UTC
After a bit of digging, searching, and grepping, I found where the enhanced
recent changes' little arrows are inserted, and if I understand correctly, it
looks like it only ever uses the graphic arrow images at
skins/common/images/Arr_*.png, depending on your bidi I presume, or at least
certainly on $arrowdir.
But to keep it skinnable, it should check in the directory of the current skin,
otherwise you get ugly results like I'm facing where you have blue arrows on a
blue background. And if I just change the includes/ChangesList.php file to point
to another directory, or simply put new image files in skins/common/images/,
then it'll be overwritten when upgrading, even though it's something that pretty
clearly should be (optionally) part of a skin.
In short, I'd like to see the code check for the file
skins/$currentskin/Arr_$arrowdir.png before it goes and uses
skins/common/images/Arr_$arrowdir.png. But I could stand to see something where
I had to set it in the $CurrentSkin.php file instead. (I'm still working out the
structure of the MediaWiki files and learning PHP, so I don't know if that would
work reasonably or not. For all I know, it might even be possible in
$CurrentSkin.php, just not something any of the skins do yet.)
Comment 1 lɛʁi לערי ריינהארט 2006-02-27 16:35:39 UTC
Hi John,

I understand that you reffer to the implementation of
Bug 2324: "Image for redirects should be without text and orientened according
to content language"

You mention 'Special:Recentchanges' in the summary. When editing a section an
'autocomment' link to this section is inserted by default into the summary.
→ is used at LTR wikies while ← at RTL wikies. This is because "→"
does *not* "change" to "←" as different types of parenthesis and other
characters "(" -> ")", "<" -> ">", "{" -> "}". 
See The Bidirectional Algorithm - Mirroring
http://www.unicode.org/reports/tr9/tr9-11.html#Mirroring
and [[wikt:yi:project:bugzilla/unicode/U_2192#BiDi]] versus
[[wikt:yi:project:bugzilla/unicode/U_0028#BiDi]].

Are any open issues here?

best regards reinhardt [[user:gangleri]]
Comment 2 Siebrand Mazeland 2009-02-02 12:39:27 UTC
Changed component to "RecentChanges"
Comment 3 Krinkle 2011-04-06 22:42:07 UTC
The javascript and html structure for enhancedchanges has been refactored in 1.18. It now uses the makeCollapsible jQuery plugin and the enhancedchanges now have custom css classes.

Skins can override the images via the class if they need to.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links