Last modified: 2011-07-13 17:34:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31755, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29755 - MediaWiki should respect no_proxy environment setting
MediaWiki should respect no_proxy environment setting
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.20.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-07 14:40 UTC by Vitaliy Filippov
Modified: 2011-07-13 17:34 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Simple function for parsing no_proxy (1.61 KB, application/octet-stream)
2011-07-07 14:40 UTC, Vitaliy Filippov
Details

Description Vitaliy Filippov 2011-07-07 14:40:01 UTC
Created attachment 8757 [details]
Simple function for parsing no_proxy

MediaWiki uses getenv('http_proxy') in HttpFunctions.php, but does not respect no_proxy environment variable. This is incorrect, because probably if MediaWiki sits behind proxy, then there is also some intranet area, accessible without proxy and probably INaccessible through proxy. :)
I suggest using the attached function for this (we use it in Mediawiki4Intranet).
Comment 1 Mark A. Hershberger 2011-07-07 15:11:15 UTC
r91642  Closing this, but would you mind submitting some unit tests for your code fragment?
Comment 2 Brion Vibber 2011-07-08 20:28:35 UTC
Was reverted in r91738 -- apparently this code has some sort of problems.

Also -- please ask for tests BEFORE committing, Mark!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links