Last modified: 2011-06-28 04:23:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31623, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 29623 - WikiLove extension doesn't validate image name input
WikiLove extension doesn't validate image name input
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiLove (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Ryan Kaldari
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-06-28 04:14 UTC by MZMcBride
Modified: 2011-06-28 04:23 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description MZMcBride 2011-06-28 04:14:01 UTC 
Running r90927 of WikiLove and trunk, the WikiLove extension doesn't seem to validate image input using the "make your own" feature. If you input an invalid file name, there's no warning to the user or prohibition from submitting the message.

The only indication from the preview of the invalid image input is "100px" (the size of the image thumbnail). This isn't intuitive. There should be a clearer error message or a red "x" icon or both. It might also make sense to stop submission if the image input is invalid; I'm unsure about that.
Comment 1 Ryan Kaldari 2011-06-28 04:16:19 UTC 
This was fixed today on trunk. It now checks to make sure the image actually exists before allowing you to proceed.
Comment 2 MZMcBride 2011-06-28 04:23:49 UTC 
Aye, fixed in r90930	 it looks like. Sorry about that. I checked out a few hours ago, but I guess you've been busy. :D
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links