Last modified: 2012-08-31 22:17:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2953 - Blocking by "other" doesn't work if the msg 'ipbotheroption' is not "other"
Blocking by "other" doesn't work if the msg 'ipbotheroption' is not "other"
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.5.x
All All
: Normal major with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-24 16:08 UTC by Carlos
Modified: 2012-08-31 22:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Carlos 2005-07-24 16:08:06 UTC
In SpecialBlock.php, function showForm(), you create the first block option with

 $blockExpiryFormOptions = "<option value=\"other\">$mIpbothertime</option>";

but later, in doSubmit(), you check if it was selected with

 if ($expirestr == wfMsg('ipbotheroption'))

I think it should be

 if ($expirestr == "other"))

Thanks.
Comment 1 Carlos 2005-07-24 16:13:49 UTC
(In reply to comment #0)
> I think it should be
> 
>  if ($expirestr == "other"))

...minus the last ")".
Comment 2 Brion Vibber 2005-07-24 17:02:15 UTC
This correction has been applied.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links