Last modified: 2011-08-01 00:09:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T31512, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 29512 - UploadStash extension weirdness
UploadStash extension weirdness
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.20.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-21 15:02 UTC by Platonides
Modified: 2011-08-01 00:09 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Platonides 2011-06-21 15:02:05 UTC
UploadStash::stashFile() wants files with extensions, so it calls getExtensionForPath(), which uses $magic->guessMimeType(), thaat returns unknown/unknown and getExtensionsForType() gives the empty string, which is appended as extension to the filename.

While we are at it, rename() should probably be inside wfSupressErrors(), and it doesn't seem too logical to set $magic = MimeMagic::singleton(); at line 215 and not use $magic at 217
Comment 1 Mark A. Hershberger 2011-06-21 23:38:21 UTC
Giving this to Bryan since he does a lot more UploadStash than Neil, I think.  (Bryan, feel free to give this to wikibugs-l if you don't want it.)
Comment 2 Neil Kandalgaonkar 2011-06-21 23:46:09 UTC
(In reply to comment #1)
> Giving this to Bryan since he does a lot more UploadStash than Neil, I think. 
> (Bryan, feel free to give this to wikibugs-l if you don't want it.)

He may have fixed some bugs recently but I wrote it ;)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links