Wikimedia Bugzilla is closed!

Works for me

On the first one, I get the diffs for all 3

On the second one, I get diffs for 2, and notcached for the last

Both for logged in and anonymous


And the most it will give you is one uncached diff, per the site config


reedy@fenari:/home/wikipedia/common/php-1.17/maintenance$ php eval.php
> echo $wgAPIMaxUncachedDiffs;
1

(In reply to comment #1)
> Works for me
> 
> On the first one, I get the diffs for all 3
> 
> On the second one, I get diffs for 2, and notcached for the last
> 
> Both for logged in and anonymous
> 
> 
> And the most it will give you is one uncached diff, per the site config
> 
Sure. But if you keep refreshing, it should eventually give you all of them, because the uncached ones it generates should be saved to cache, right? Except that's not what happens, and that's what this bug is about.

(In reply to comment #2)
> (In reply to comment #1)
> > Works for me
> > 
> > On the first one, I get the diffs for all 3
> > 
> > On the second one, I get diffs for 2, and notcached for the last
> > 
> > Both for logged in and anonymous
> > 
> > 
> > And the most it will give you is one uncached diff, per the site config
> > 
> Sure. But if you keep refreshing, it should eventually give you all of them,
> because the uncached ones it generates should be saved to cache, right? Except
> that's not what happens, and that's what this bug is about.

Nice when people explain things ;)


Cause is simple, the diffs are not even attempted to be cached afterwards by the API

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Works for me
> > > 
> > > On the first one, I get the diffs for all 3
> > > 
> > > On the second one, I get diffs for 2, and notcached for the last
> > > 
> > > Both for logged in and anonymous
> > > 
> > > 
> > > And the most it will give you is one uncached diff, per the site config
> > > 
> > Sure. But if you keep refreshing, it should eventually give you all of them,
> > because the uncached ones it generates should be saved to cache, right? Except
> > that's not what happens, and that's what this bug is about.
> 
> Nice when people explain things ;)
> 
> 
> Cause is simple, the diffs are not even attempted to be cached afterwards by
> the API

Bleh, the DifferenceEngine doesn't believe it should be cached for whatever reason

WHIIIIICCCCHHHH probably means it's not technically an API bug

(In reply to comment #5)
> WHIIIIICCCCHHHH probably means it's not technically an API bug
Well presumably diffs viewed through the UI get cached...

if ( !is_null( $this->difftotext ) ) {
					$engine = new DifferenceEngine( $title );
					$engine->setText( $text, $this->difftotext );
				} else {
					$engine = new DifferenceEngine( $title, $revision->getID(), $this->diffto );
					$vals['diff']['from'] = $engine->getOldid();
					$vals['diff']['to'] = $engine->getNewid();
				}
				$difftext = $engine->getDiffBody();





	function __construct( $titleObj = null, $old = 0, $new = 0, $rcid = 0,
		$refreshCache = false, $unhide = false )


And then it'll only do it if...

		if ( $this->mOldid && $this->mNewid ) {


So in some cases.

I'll look at looking into it properly later

(In reply to comment #7)

> I'll look at looking into it properly later

So, it is now "later"... Is this resolved?

(In reply to comment #8)
> (In reply to comment #7)
> o
> > I'll look at looking into it properly later
> 
> So, it is now "later"... Is this resolved

One would presume as the bug is still open, it isn't resolved...

Are there any chances to get this issue solved?

This is low priority, so providing a patch would help speed up things. See https://www.mediawiki.org/wiki/Developer_access if you are interested.