Last modified: 2010-05-15 15:37:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2894 - Enhanced Recent Changes links time to previous version and cur does not give cumulative diff
Enhanced Recent Changes links time to previous version and cur does not give ...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.5.x
All All
: Normal normal with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-07-18 08:16 UTC by patrick.wikipedia
Modified: 2010-05-15 15:37 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch of includes/ChangesList.php for fixing this bug. (1.33 KB, patch)
2005-11-23 17:18 UTC, P. K. CHAN, Esq.
Details
Patch for 1.6 (CVS HEAD) (1.62 KB, patch)
2005-11-23 18:06 UTC, Brion Vibber
Details
Patch for REL1_5, with link fix (1.61 KB, patch)
2005-11-23 18:38 UTC, Brion Vibber
Details

Description patrick.wikipedia 2005-07-18 08:16:41 UTC
Enhanced Recent Changes gives, for pages for 
which there are multiple edits, after pressing 
the downward arrow, on each line:

- the time, linked to the page version 
just ''before'' this time, instead of the 
version created at this time

- the link "cur" to the diff page for the edit 
concerned, just like "last", instead of the 
cumulative diff
Comment 1 patrick.wikipedia 2005-07-18 09:13:31 UTC
I suggest uniformity with the links on the Page 
History page:

with regard to the time link (on the Page 
History page with date): link to the version 
created then

with regard to "cur": link to the cumulative 
diff of the edits after (hence not including) 
the one at the specified time
Comment 2 P. K. CHAN, Esq. 2005-10-31 08:47:46 UTC
Reproducible on 1.5.0.
Comment 3 P. K. CHAN, Esq. 2005-11-22 02:23:48 UTC
May I know the status of this bug?  It is a grave error on the software because
the links provided link to the wrong version/diff -- and for an intensive online
collaboration of critical contents this may prove fatal as the wrong version may
have been reverted.

It's reproducible on 1.5.2.
Comment 4 P. K. CHAN, Esq. 2005-11-23 17:18:02 UTC
Created attachment 1091 [details]
Patch of includes/ChangesList.php for fixing this bug.

Can't wait for the fix, so attempted my own: patch for making the changes list
on Enhanced Recent Changes in line with that of the page history, with the
following two changes:

i.  the timestamp (of an entry as expanded from a page with multiple edits) now
links to the version saved as of that time, and not the previous version;
ii.  the "cur" link (of an entry as expanded from a page with multiple edits)
now links to the cumulative diff from the version saved as of that time to the
current version.

This patch works on my site.  However I do not profess to be familiar with the
relevant code so 1. this may have broken a few other things and 2. it may have
violated some design philosophy.  Two questions specifically in my mind are:

a.  I do not know how to generate the latest version id on ChangesList.php (as
in the function getLatestID in PageHistory.php), so I just used the old method
(as in 1.4.*) and supply zero as the current version for the cumulative diff
link.

b.  I don't quite understand why is the same $query shared for the "cur" and
"diff" links when apparently these two serve different purposes; I just split
them up into $querycur and $querydiff for the two purposes as a result.
Comment 5 Brion Vibber 2005-11-23 17:54:40 UTC
Patch does not apply to CVS HEAD.

Trying to fix...
Comment 6 Brion Vibber 2005-11-23 18:06:45 UTC
Created attachment 1092 [details]
Patch for 1.6 (CVS HEAD)

Also fixes the diff links to use the correct version.
Comment 7 Brion Vibber 2005-11-23 18:38:54 UTC
Created attachment 1093 [details]
Patch for REL1_5, with link fix

Fixed version of the patch for 1.5.

If a page's first revision was in the list, the time-link was missing the
revision number so would link to the current version instead.
Comment 8 Brion Vibber 2005-11-23 18:45:07 UTC
Committed to HEAD and REL1_5. Thanks for the fix!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links