Last modified: 2010-05-15 15:37:34 UTC
Enhanced Recent Changes gives, for pages for
which there are multiple edits, after pressing
the downward arrow, on each line:
- the time, linked to the page version
just ''before'' this time, instead of the
version created at this time
- the link "cur" to the diff page for the edit
concerned, just like "last", instead of the
I suggest uniformity with the links on the Page
with regard to the time link (on the Page
History page with date): link to the version
with regard to "cur": link to the cumulative
diff of the edits after (hence not including)
the one at the specified time
Reproducible on 1.5.0.
May I know the status of this bug? It is a grave error on the software because
the links provided link to the wrong version/diff -- and for an intensive online
collaboration of critical contents this may prove fatal as the wrong version may
have been reverted.
It's reproducible on 1.5.2.
Created attachment 1091 [details]
Patch of includes/ChangesList.php for fixing this bug.
Can't wait for the fix, so attempted my own: patch for making the changes list
on Enhanced Recent Changes in line with that of the page history, with the
following two changes:
i. the timestamp (of an entry as expanded from a page with multiple edits) now
links to the version saved as of that time, and not the previous version;
ii. the "cur" link (of an entry as expanded from a page with multiple edits)
now links to the cumulative diff from the version saved as of that time to the
This patch works on my site. However I do not profess to be familiar with the
relevant code so 1. this may have broken a few other things and 2. it may have
violated some design philosophy. Two questions specifically in my mind are:
a. I do not know how to generate the latest version id on ChangesList.php (as
in the function getLatestID in PageHistory.php), so I just used the old method
(as in 1.4.*) and supply zero as the current version for the cumulative diff
b. I don't quite understand why is the same $query shared for the "cur" and
"diff" links when apparently these two serve different purposes; I just split
them up into $querycur and $querydiff for the two purposes as a result.
Patch does not apply to CVS HEAD.
Trying to fix...
Created attachment 1092 [details]
Patch for 1.6 (CVS HEAD)
Also fixes the diff links to use the correct version.
Created attachment 1093 [details]
Patch for REL1_5, with link fix
Fixed version of the patch for 1.5.
If a page's first revision was in the list, the time-link was missing the
revision number so would link to the current version instead.
Committed to HEAD and REL1_5. Thanks for the fix!