Last modified: 2011-05-09 17:46:35 UTC
Seeing all sorts of lovely things like this: PHP Notice: Use of undefined constant UTF8_REPLACEMENT - assumed 'UTF8_REPLACEMENT' in /var/www/trunk/includes/normal/UtfNormal.php on line 246 PHP Notice: Use of undefined constant UTF8_FFFE - assumed 'UTF8_FFFE' in /var/www/trunk/includes/normal/UtfNormal.php on line 388 PHP Notice: Use of undefined constant UTF8_FFFF - assumed 'UTF8_FFFF' in /var/www/trunk/includes/normal/UtfNormal.php on line 389 5. when attempting 'make test' or 'make bench' in includes/normal. It seems that these constants are defined in UtfNormalDefines.php, but UtfNormalDefines.php is not included by UtfNormal.php. Ouch! Looks like regression from r85327 -- I don't just want to revert it since the split is deliberate for HipHop compatibility. Probably just need a require_once in UtfNormal.php?
r87748 restores the original version of the require_once line to UtfNormalBench.php which had been moved away in r85944 (without the MWInit::compiledPath call added in r85327 which caused it to simply break 100% on the generator, test, and benchmark code which does not depend on the rest of MediaWiki). This doesn't seem to have any problems with regular MediaWiki -- as the file is already now included from Setup.php -- but it might have some effect on HipHop builds, untested. Please double-check affected features.
