Last modified: 2014-03-23 20:28:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 28827 - PHP Catchable fatal error: Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given
PHP Catchable fatal error: Argument 1 passed to RequestContext::setTitle() m...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
: testme
: 34446 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-05 07:49 UTC by Niklas Laxström
Modified: 2014-03-23 20:28 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Niklas Laxström 2011-05-05 07:49:09 UTC
Related to the recent RequestContext introduction, but too lazy to dig up anymore when this was introduced. Filing a bug because of poking people in IRC hasn't had any effect on fixing this bug.
Comment 1 Brion Vibber 2011-05-09 23:35:05 UTC
Can you paste the error line (or backtrace if available)? Haven't reproduced this yet, should be easier to find if we've got a detailed ping.
Comment 2 Mark A. Hershberger 2011-05-10 01:41:03 UTC
Assigning to dantman since he seems to be responsible for this area.
Comment 3 Niklas Laxström 2011-05-10 06:31:22 UTC
Right I forgot the line numbers:

PHP Catchable fatal error:  Argument 1 passed to RequestContext::setTitle() must be an instance of Title, null given, called in /www/w/includes/OutputPage.php on line 795 and defined in /www/w/includes/RequestContext.php on line 47


x.x.x.x translatewiki.net - [09/May/2011:20:20:33 +0000] "POST /w/api.php HTTP/1.1" 500 37
Comment 4 Daniel Friesen 2011-05-10 06:41:01 UTC
That's a little shallow. No real information where the bad title is coming from.
Comment 5 Niklas Laxström 2011-05-10 06:43:18 UTC
It's everything I have without trying to spend all my time debugging it myself!
Comment 6 Mark A. Hershberger 2011-06-17 00:16:24 UTC
Is this still showing up?
Comment 7 Niklas Laxström 2011-06-17 10:33:54 UTC
Yes.

[15-Jun-2011 15:08:26] PHP Catchable fatal error:  Argument 1 passed to OutputPage::setTitle() must be an instance of Title, null given, called in /www/w/extensions/LiquidThreads/classes/View.php on line 381 and defined in /www/w/includes/OutputPage.php on line 812

BTW I suggest adding type hint to OutputPage::setTitle to catch these errors easier.
Comment 8 Mark A. Hershberger 2011-07-28 13:36:43 UTC
unassign Daniel Friesen after talking to him
Comment 9 Niklas Laxström 2011-07-28 17:49:43 UTC
Implemented my suggestion in r93404. The cause is actually in LQT -- so no quick fix to be seen.
Comment 10 Daniel Friesen 2011-07-29 00:18:16 UTC
It would be nice if that change was included by a null check and a wfDebug call... since extensions trying to set the current page title to null IS a bug.
Comment 11 Niklas Laxström 2011-07-29 05:52:39 UTC
Why? The type hint will already cause PHP to give the exact line of the caller and fail fast.
Comment 12 Daniel Friesen 2011-07-29 06:02:40 UTC
Heh, n/m sorry... I read the diff the wrong way, it looked like you were removing one of the type hints we already had so that the null would be passed through and not throw an error.

Go ahead and add a Title type hint to any setTitle method related to RequestContext code. If PHP had mixins a type hint like that would be part of the standard mixin.
Comment 13 Niklas Laxström 2011-11-02 14:45:50 UTC
Okay, the issue prevents me to post new messages in this url as anonymous user: http://translatewiki.net/wiki/User_talk:Dsvyas
Comment 14 Alex Monk 2012-10-28 17:43:56 UTC
*** Bug 34446 has been marked as a duplicate of this bug. ***
Comment 15 Alex Monk 2012-10-28 19:02:39 UTC
I got this issue earlier when trying to create a new thread on a user talk page as an anonymous user...
Comment 16 Sam Reed (reedy) 2012-11-01 17:52:25 UTC
Showing in the error logs quite a lot at teh moment...
Comment 17 Sam Reed (reedy) 2012-11-01 17:53:32 UTC
PHP Catchable fatal error:  Argument 1 passed to OutputPage::setTitle() must be an instance of Title, null given, called in /usr/local/apache/common-local/php-1.21wmf3/extensions/LiquidThreads/classe
s/View.php on line 450 and defined in /usr/local/apache/common-local/php-1.21wmf3/includes/OutputPage.php on line 850
Comment 18 Nischay Nahata 2013-04-07 05:56:52 UTC
I tried to post a new thread on a user talk page from incognito (anonymous user) and it went well, did I do something wrong to not reproduce this error?
Comment 19 Nemo 2013-08-30 05:55:07 UTC
(In reply to comment #18)
> I tried to post a new thread on a user talk page from incognito (anonymous
> user) and it went well, did I do something wrong to not reproduce this error?

There are no steps to reproduce. The error is not seen any longer on twn, but that may be because unregistered users are now restricted from LQT.

Reedy, do you see this in the logs still?
Comment 20 Nemo 2013-08-30 06:10:35 UTC
Thanks to Ori:

[29-Aug-2013 15:45:50] Catchable fatal error: Argument 1 passed to EditPage::__construct() must be an instance of Article, null given, called in 
               /usr/local/apache/common-local/php-1.22wmf14/extensions/LiquidThreads/classes/View.php on line 734 and defined at 
               /usr/local/apache/common-local/php-1.22wmf14/includes/EditPage.php on line 272
Comment 21 Andre Klapper 2013-09-02 11:29:48 UTC
agarrett: Any chance that you could take a look at this?
Comment 22 Sam Reed (reedy) 2013-10-11 00:09:49 UTC
https://gerrit.wikimedia.org/r/#/c/88189/ might have fixed this...
Comment 23 Andre Klapper 2014-01-09 11:43:09 UTC
Does this still happen (asking due to comment 22) or can this be closed as WORKSFORME nowadays?
Comment 24 Andre Klapper 2014-03-23 18:15:23 UTC
Does this still happen (asking due to comment 22) or can this be closed as WORKSFORME nowadays?
Comment 25 Nemo 2014-03-23 20:28:40 UTC
(In reply to Sam Reed (reedy) from comment #22)
> https://gerrit.wikimedia.org/r/#/c/88189/ might have fixed this...

Doesn't look so:

2014-01-22 19.00 -rakkaus:#mediawiki-i18n- [22-Jan-2014 18:00:47 UTC] PHP Catchable fatal error:  Argument 1 passed to OutputPage::setTitle() must be an instance of Title, null given, called in /www/translatewiki.net/w/extensions/LiquidThreads/classes/View.php on line 450 and defined in /www/translatewiki.net/w/includes/OutputPage.php on line 910

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links