Last modified: 2014-08-17 11:29:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30826, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28826 - LiquidThreads: Fix "PHP Notice: Undefined variable: _SESSION in View.php on line 415"
LiquidThreads: Fix "PHP Notice: Undefined variable: _SESSION in View.php on ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 37333 (view as bug list)
Depends on:
Blocks: 39480
  Show dependency tree / graph
 
Reported: 2011-05-05 07:46 UTC by Niklas Laxström
Modified: 2014-08-17 11:29 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2011-05-05 07:46:24 UTC 
[05-May-2011 03:05:20] PHP Notice:  Undefined variable: _SESSION in /www/w/extensions/LiquidThreads/classes/View.php on line 361
[05-May-2011 03:05:20] PHP Warning:  Invalid argument supplied for foreach() in /www/w/extensions/LiquidThreads/classes/View.php on line 361

This has started happening relatively recently.
Comment 1 Brion Vibber 2011-05-05 18:18:28 UTC 
Seems to be related to r84007 which attempted to fix bug 27887.
Comment 2 Bugmeister Bot 2011-08-19 19:12:17 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Niklas Laxström 2012-11-15 07:23:05 UTC 
Still happening.
Comment 4 Niklas Laxström 2012-11-15 07:23:16 UTC 
*** Bug 37333 has been marked as a duplicate of this bug. ***
Comment 5 Niklas Laxström 2012-11-15 07:25:04 UTC 
Line number has changed (or another issue?) though: PHP Notice:  Undefined variable: _SESSION in /www/translatewiki.net/w/extensions/LiquidThreads/classes/View.php on line 415
Comment 6 Niklas Laxström 2013-06-16 21:00:26 UTC 
Still happening.
Comment 7 Nemo 2013-12-29 21:36:21 UTC 
Today quite a spree of these.
Comment 8 Krinkle 2014-05-29 11:38:16 UTC 
This was attempted to be fixed in 2011:

https://github.com/wikimedia/mediawiki-extensions-LiquidThreads/commit/f2caf1cdf20c3604fe1e635b9d8e869575f751fa

But that only made it worse by now iterating over array(null) instead of not iterating and emitting a notice for loop over non-iterable.
Comment 9 Gerrit Notification Bot 2014-05-29 11:41:43 UTC 
Change 136012 had a related patch set uploaded by Krinkle:
View.php: Fix notice for undefined _SESSION

https://gerrit.wikimedia.org/r/136012
Comment 10 Gerrit Notification Bot 2014-05-29 15:32:42 UTC 
Change 136012 merged by jenkins-bot:
View.php: Fix notice for undefined _SESSION

https://gerrit.wikimedia.org/r/136012
Comment 11 Andre Klapper 2014-08-17 11:29:01 UTC 
Patch mentioned in this report was merged - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links