Last modified: 2011-09-08 18:29:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30818, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28818 - UploadWizard insertCat error
UploadWizard insertCat error
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-05-04 23:05 UTC by Neil Kandalgaonkar
Modified: 2011-09-08 18:29 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Neil Kandalgaonkar 2011-05-04 23:05:29 UTC 
On FF4, some users get 'cat.replace is not a function' when trying to upload

Seems to be related to the lack of an autoCategory in the config; it is defaulting to false which causes some problem
Comment 1 Brion Vibber 2011-05-04 23:08:25 UTC 
Changing the check in mw.UploadWizardDetails.js should fix it:

	var hiddenCats = [];
	if ( mw.isDefined( mw.UploadWizard.config.autoCategory ) ) {
		hiddenCats.push( mw.UploadWizard.config.autoCategory );
	}

mw.isDefined checks for the JS 'undefined' type, so returns true for false, null, empty string, etc.
Comment 2 Bugmeister Bot 2011-08-19 19:12:39 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Neil Kandalgaonkar 2011-09-08 18:29:55 UTC 
Seems to be fixed, since the category suggest stuff was rewritten substantially. Tested with FF 4.x and also verified that no "replace" call occurs without the object already existing and known to be a string. Some $input.val() calls may return non-string, so added test in r96591 to throw error if this ever occurs (would only happen if we accidentally selected a non-textual input).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links