Last modified: 2011-05-04 04:26:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30800, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28800 - [Edittools] Plus sign ("+") broken
[Edittools] Plus sign ("+") broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CharInsert (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Brion Vibber
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-03 18:03 UTC by Krinkle
Modified: 2011-05-04 04:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2011-05-03 18:03:34 UTC
With the following in MediaWiki:Edittools:

<charinsert> € £ ¥ $ ¢ © ® ™ </charinsert> ·
<charinsert> « + » {{+}} </charinsert>
<charinsert> — – ‘ “ ’ ” | … ~ # @ § ¶ • ¡ ¿ \ </charinsert>


I get the following HTML output (see second line) on all edit pages:

<a onclick="insertTags(&#39;«&#39;,&#39;&#39;,&#39;&#39;);return false" href="#">«</a> 
<a onclick="insertTags(&#39;&#39;,&#39;&#39;,&#39;&#39;);return false" href="#" /> 
<a onclick="insertTags(&#39;»&#39;,&#39;&#39;,&#39;&#39;);return false" href="#">»</a> 


Which triggers the following DOM error in WebKit:
* XML self-closing tag syntax used on <a>. The tag will not be closed.

And in the end result, it doesn't work. (unclickable ofcourse).


The HTML output when viewing the message-page is slightly different:


 <a onclick="insertTags('«','','');return false" href="#">«</a>
 <a onclick="insertTags('','','');return false" href="#"></a>
 <a onclick="insertTags('»','','');return false" href="#">»</a>
Comment 1 Krinkle 2011-05-03 18:04:15 UTC
I tried[1] fixing it with <nowiki>-tags but no luck.

[1] http://sq.wikipedia.org/w/index.php?title=MediaWiki%3AEdittools&diff=943808&oldid=602826
Comment 2 Bawolff (Brian Wolff) 2011-05-04 04:23:40 UTC
fixed r87386.
Comment 3 Bawolff (Brian Wolff) 2011-05-04 04:26:39 UTC
As an aside, the code on sq probably meant to do:

<charinsert>«+» {{+}}</charinsert>

Which causes « before the cursor and » after the cursor when you insert (or surround text if highlighted), since most keyboards have a + key, while « and » are more rare.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links