Last modified: 2011-06-30 18:57:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30794, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28794 - Verify that Upload by URL and job runners is not affected by ChronologyProtector fix
Verify that Upload by URL and job runners is not affected by ChronologyProtec...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
1.18.x
All All
: Highest normal (vote)
: ---
Assigned To: Bryan Tong Minh
:
Depends on:
Blocks: 29068
  Show dependency tree / graph
 
Reported: 2011-05-03 12:56 UTC by Mark A. Hershberger
Modified: 2011-06-30 18:57 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2011-05-03 12:56:25 UTC 
Bug 27891 was fixed by r87235 which removed session_write_close() so it wouldn't disturb ChronologyProtector.  Tim has already put a FIXME on r72475, but I'm opening this bug so that I can track this issue.
Comment 1 Bryan Tong Minh 2011-05-03 13:05:08 UTC 
The affected component is not UploadStash, but asynchronous upload-by-url. Or more generally, job runners that access the session and that are run at the end of a normal request rather than via runJobs.php. It is possible that they will destroy the current session, but I need to look into the code to verify that.
Comment 2 Mark A. Hershberger 2011-05-03 15:49:50 UTC 
Thanks, updated the summary.
Comment 3 Mark A. Hershberger 2011-06-12 17:44:33 UTC 
Bryan, have you had a chance to look at this yet? Results?
Comment 4 Mark A. Hershberger 2011-06-30 18:57:51 UTC 
fixme has been marked resolved 3 days ago.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links