Last modified: 2011-06-13 15:57:42 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30782, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28782 - UploadWizard: thumbnails on live Commons often missing; duplicate fetches of same thumbnail
UploadWizard: thumbnails on live Commons often missing; duplicate fetches of ...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UploadWizard (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Neil Kandalgaonkar
:
: 26001 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-02 19:56 UTC by Neil Kandalgaonkar
Modified: 2011-06-13 15:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-05-02 19:56:50 UTC
Live Commons often is slow to generate thumbnails due to thumbnail server overloading, or because the generation occurs in a shelled-out process.

Our stashImageInfo calls only return the URLs of where the thumbnails are *supposed* to be. It doesn't mean these URLs won't return errors for some amount of time.

The result is that thumbnails are not ready when they are asked for, resulting in 404 errors. These errors are then cached within UploadWizard.

Related: we also fetch the same thumbnail (same specifications) too many times. If we want the same thumbnail on two different pages it gets fetched twice.

The solution is to use a mini publish-and-subscribe system within the UploadWizard, that checks for the availability of thumbnails and then updates the interface when they are ready.
Comment 1 Neil Kandalgaonkar 2011-05-02 19:58:36 UTC
*** Bug 26001 has been marked as a duplicate of this bug. ***
Comment 2 Neil Kandalgaonkar 2011-05-03 03:05:25 UTC
Should be largely fixed by r87314 but need to do a bit more testing
Comment 3 Neil Kandalgaonkar 2011-06-13 15:57:42 UTC
Seems to definitely be fixed as of r89918, which has the pubsub system described in the first comment. Also some later thumbnails (like the thanks page) were fetched via API all over again due to not specifying the height parameter, so they looked like different thumbnails.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links