Last modified: 2011-04-27 20:06:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30719, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28719 - Do not call mLinkHolders __destruct explicitly
Do not call mLinkHolders __destruct explicitly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-27 15:50 UTC by Vitaliy Filippov
Modified: 2011-04-27 20:06 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
simple patch (559 bytes, patch)
2011-04-27 15:50 UTC, Vitaliy Filippov 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Vitaliy Filippov 2011-04-27 15:50:08 UTC 
Created attachment 8469 [details]
simple patch

Calling $this->mLinkHolders->__destruct(); explicitly is incorrect because it sometimes leads to strange errors. I can't tell exactly which errors... :) because our wiki distribution (wiki.4intra.net) is patched manually since 1.13 :)
I think you should use unset( $this->mLinkHolders ) and let PHP run the destructor.
Comment 1 Sam Reed (reedy) 2011-04-27 20:06:02 UTC 
Makes sense to me, we're using unset() beneath that

Thanks

r87039
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links