Last modified: 2011-04-28 14:59:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30699, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28699 - Some small improvements for the mw.log() box
Some small improvements for the mw.log() box
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-25 16:23 UTC by Bergi
Modified: 2011-04-28 14:59 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch (874 bytes, patch)
2011-04-25 16:23 UTC, Bergi
Details

Description Bergi 2011-04-25 16:23:17 UTC
Created attachment 8461 [details]
proposed patch

The log box for console-less browsers doesn't show linebreaks, and it hides 150px at the bottom of the page.
I'm not sure who would try to debug mw javascript in a console-less browser, but this simple patch won't hurt :-)

For testing it you might have to type 'console.log=""' in your console before typing 'mw.log("test\n linebreak")'.
Comment 1 Brion Vibber 2011-04-25 18:06:48 UTC
The pre-wrap seems to turn \n into nice line breaks (yay), but I don't think the fix for the hidden bits at the bottom works.

I still can't scroll down to the very bottom of the page in IE 8; the console window still blocks off.

(Unable to get the in-browser console to show on any of my other browsers, as they all have modern debug consoles in the system.)
Comment 2 Bergi 2011-04-26 12:28:59 UTC
IE 9 works for me, I can't test version 8.*.

For browsers with a console try javascript:void(console.log=""); before some javascript:void(mw.log("Hallo\n Welt"));
Comment 3 Mark A. Hershberger 2011-04-27 23:19:38 UTC
Giving to Trevor for review.
Comment 4 Trevor Parscal 2011-04-28 14:59:26 UTC
Works in other Internet Explorer versions as well - and has been tested in Vector, Monobook and Modern. I applied this in r87077.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links