Last modified: 2011-04-23 19:40:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30618, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28618 - {{filepath}} does not deliver full URL
{{filepath}} does not deliver full URL
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.18.x
All All
: Normal critical (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-20 11:47 UTC by Owltom
Modified: 2011-04-23 19:40 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Owltom 2011-04-20 11:47:11 UTC
Instead of the full URL it only shows the part after Server.

Example from our Wiki:

{{filepath:Wiki.png}}

delivers : /images/b/bc/Wiki.png
should be: http://kamelopedia.mormo.org/images/b/bc/Wiki.png

r80813 broke it [r1=80512&r2=80813&sortby=date">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/parser/CoreParserFunctions.php?r1=80512&r2=80813&sortby=date]

line 639: $url = $file->getUrl();
I think should be: $url = $file->getFullUrl();

Sorry for my poor english ;)
Comment 1 Roan Kattouw 2011-04-20 11:58:47 UTC
Assigning to Krinkle because he broke this.
Comment 2 Krinkle 2011-04-23 19:39:10 UTC
I also added wfExpandUrl.

See http://translatewiki.net/w/i.php?title=Sandbox&oldid=2941239 for comparison.

Only local non-thumb are affected.

I remember there was a reason I changed it to getUrl, but I believe it's no longer relevant.

Fixed in r86788.
Comment 3 Krinkle 2011-04-23 19:40:00 UTC
(In reply to comment #2)
> I also added a wfExpandUrl.

I meant that I added it in the initial commit in January (r80813).

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links