Last modified: 2012-01-22 12:51:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30589, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28589 - Pages protected by title blacklist extension show "edit" tab instead of "view source" even if the editor cannot edit them
Pages protected by title blacklist extension show "edit" tab instead of "view...
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
TitleBlacklist (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Victor Vasiliev
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-18 01:24 UTC by 28bytes
Modified: 2012-01-22 12:51 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description 28bytes 2011-04-18 01:24:22 UTC
Example: if a non-logged-in user pulls up http://en.wikipedia.org/wiki/Template:Editnotices/Page/Template_talk:Did_you_know

...they are presented with an Edit tab, even though they cannot edit it.
Comment 1 Chad H. 2011-04-20 03:19:17 UTC
Is this related to bug 14104?
Comment 2 Bawolff (Brian Wolff) 2011-04-20 04:01:22 UTC
Based on talk on irc, this page is protected via title blacklist extension.

The title blacklist extension uses the getUserPermissionsErrorsExpensive hook, which means that its only checked when we absolutely have to (aka on an actual edit, not on when we decide what to display the edit tab as). I have no idea how expensive title blacklist is, but presumably its using that hook for a reason and probably isn't going to change.

However, with that said when we're actually on an edit page (aka http://en.wikipedia.org/w/index.php?title=Template:Editnotices/Page/Template_talk:Did_you_know&action=edit ) we do have to do the expensive check, and we should probably re-use that when building the skin elements. (However I'm not sure how easy that'd be to do in practice).
Comment 3 db [inactive,noenotif] 2011-04-20 19:19:14 UTC
(In reply to comment #1)
> Is this related to bug 14104?

It is bug 11700
Comment 4 Victor Vasiliev 2012-01-22 12:51:36 UTC
Will not fix. Checking pages against a list of regexes on every page view is expensive.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links