Last modified: 2012-09-27 01:11:05 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30561, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28561 - CSS class "small" makes link text smaller than regular text
CSS class "small" makes link text smaller than regular text
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.17.x
All All
: Low minor (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-15 20:11 UTC by Dan Barrett
Modified: 2012-09-27 01:11 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Screenshot of the two test cases in the ticket, on English Wikipedia running 1.17wmf1 (r86086) (4.42 KB, image/png)
2011-04-15 20:13 UTC, Dan Barrett
Details

Description Dan Barrett 2011-04-15 20:11:00 UTC
This occurs in both Vector and Monobook. When you apply the CSS "small" to text that contains a link, the link text is slightly smaller than the regular text. They should be the same size.

Test cases:

<span class="small">Blah [[Blah]]</span>

{|table class="small"
| Blah [[Blah]]
|}
Comment 1 Dan Barrett 2011-04-15 20:13:13 UTC
Created attachment 8407 [details]
Screenshot of the two test cases in the ticket, on English Wikipedia running 1.17wmf1 (r86086)
Comment 2 Bawolff (Brian Wolff) 2011-04-15 20:36:30 UTC
This has been here for a while (looks like since r51086)

From what I can tell cause is the rule on line 1021 of screen.css:

.small, .small * {
        font-size: 94%;
}

This would cause <span class="small">outer<span>inner</span></span> to have the font-size: 94% be applied to the "inner" text twice. (if there were more nested times it'd be applied even more. This goes for any tag, not just span). Solution would be to just remove the * part of that rule. What problem was that rule trying to solve?
Comment 3 Dan Barrett 2011-04-15 20:41:58 UTC
Actually the bug predates r51086. It's found in skins/monobook/main.css as well.
Comment 4 Bawolff (Brian Wolff) 2011-04-15 20:46:33 UTC
Wow, no kidding. Added in r4185 (28 June 2004).

I think we should just kill the *. The behaviour does not make sense (it will also match bold tags for example), I can't imagine anyone relying on it. Or replace it with

.small, .small .small, .small .small .small {
        font-size: 94%;
}

To support nested .small (what I expect is the original intent).
Comment 5 Happy-melon 2011-04-15 20:54:46 UTC
Just applying the tag to .small nests correctly on FF4 (as in, each level of nesting is smaller than the one above it).  Don't know about other browsers.
Comment 6 Bawolff (Brian Wolff) 2011-04-15 20:58:33 UTC
(In reply to comment #5)
> Just applying the tag to .small nests correctly on FF4 (as in, each level of
> nesting is smaller than the one above it).  Don't know about other browsers.

Right. It should on any browser that supports css nesting, i just got myself confused there.

Anyways removed the rule in r86138.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links