Last modified: 2011-06-13 19:01:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30556, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 28556 - UploadBase::checkMacBinary should be removed
UploadBase::checkMacBinary should be removed
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Mark A. Hershberger
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-04-15 18:10 UTC by Neil Kandalgaonkar
Modified: 2011-06-13 19:01 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Neil Kandalgaonkar 2011-04-15 18:10:12 UTC 
In UploadBase::checkMacBinary, if a file is discovered to have MacBinary encoding, a new file is created from the data fork, and the upload is modified so its mTempPath now points to this new file.

This doesn't use the FileRepo abstractions for temporary file storage, and it should. Otherwise this will be a problem for some new network file storage implementations which aren't mounted on the filesystem.
Comment 1 Bryan Tong Minh 2011-04-22 18:32:44 UTC 
This is a left over of Internet Explorer for Mac. As far as I know modern Mac browsers are not using MacBinaries. We could just kill it.
Comment 2 Brion Vibber 2011-06-06 23:32:27 UTC 
I would not object to removing it at this point. IE 5 for Mac was the only known user of this code, and it's so broken nothing works with it anymore hardly. ;)
Comment 3 Mark A. Hershberger 2011-06-07 02:23:18 UTC 
fixed summary, assigned to self.
Comment 4 Krinkle 2011-06-13 19:01:08 UTC 
Fixed in r89995.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links