Last modified: 2011-07-26 16:53:42 UTC
r33149 added a database field ar_parent_id to the archive table, but it is never used inside mediawiki. Please fill that field on deletion and reuse it on undeletion. That save calls to getPreviousRevisionId() (in insertOn()) on undeletion to populate that field. Thanks.
(In reply to comment #0) > r33149 added a database field ar_parent_id to the archive table, but it is > never used inside mediawiki. > > Please fill that field on deletion and reuse it on undeletion. > Filling on deletion seems to happen (I see non-null values in it on the toolserver), except for old deletions. Using it on undeletion is bug 26123. *** This bug has been marked as a duplicate of bug 26123 ***
(In reply to comment #1) > (In reply to comment #0) > > r33149 added a database field ar_parent_id to the archive table, but it is > > never used inside mediawiki. > > > > Please fill that field on deletion and reuse it on undeletion. > > > Filling on deletion seems to happen (I see non-null values in it on the > toolserver), except for old deletions. Using it on undeletion is bug 26123. > *** This bug has been marked as a duplicate of bug 26123 *** Have you look at the archive table for the *parent*_id and not for the *page*_id? On my trunk installation the parent_id is always null (but the page_id is filled). I have not found any code for set or update that field.
(In reply to comment #2) > Have you look at the archive table for the *parent*_id and not for the > *page*_id? /me bangs head into desk repeatedly > On my trunk installation the parent_id is always null (but the page_id is > filled). I have not found any code for set or update that field. Yup, all nulls there.
See r93205. I thought this was done already.
