Last modified: 2014-01-10 00:38:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30481, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28481 - hhvm: ext/mysql throws needless notices on query failures
hhvm: ext/mysql throws needless notices on query failures
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.18.x
All All
: Normal minor (vote)
: ---
Assigned To: Chad H.
: hhvm, upstream
: 54840 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-10 18:57 UTC by Chad H.
Modified: 2014-01-10 00:38 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Chad H. 2011-04-10 18:57:55 UTC
Not terribly important, but annoying. I get the following for calls to Database::tableExists() in my logs:

HipHop Notice:  runtime/ext_mysql: failed executing [SELECT /* DatabaseBase::tableExists 24.125.174.151 */ 1 FROM `mw_cur` LIMIT 1] [Table 'wikidb.mw_cur' doesn't exist]
Comment 1 Tim Starling 2011-04-11 00:14:51 UTC
You should file it upstream if it can't be disabled. MediaWiki has its own logging system for query errors we actually care about, we don't need HipHop's.
Comment 2 Andre Klapper 2013-08-08 07:51:29 UTC
Is this still an issue nowadays?
Comment 3 Ori Livneh 2013-09-16 09:01:03 UTC
They're PHP E_NOTICEs and can be silenced in the usual ways.
Comment 4 Chad H. 2013-10-04 19:56:42 UTC
(In reply to comment #3)
> They're PHP E_NOTICEs and can be silenced in the usual ways.

Not true. I tried silencing them with wfSuppressWarnings(), didn't work. @ worked, but it's evil. I filed bug 54840 about this same issue...I had forgotten this old bug existed.
Comment 5 Chad H. 2013-10-07 21:20:58 UTC
*** Bug 54840 has been marked as a duplicate of this bug. ***
Comment 6 Chad H. 2013-10-07 21:22:19 UTC
This only applies to ext/mysql in hhvm, not zend or sqlite or anything else.

Since we already handle the errors ourselves, I went ahead and just silenced them in Gerrit change #87281.
Comment 7 Chad H. 2013-10-10 00:50:56 UTC
(In reply to comment #1)
> You should file it upstream if it can't be disabled. MediaWiki has its own
> logging system for query errors we actually care about, we don't need
> HipHop's.

I should've listened to Tim a long time ago.

Should be handled in master soon: https://github.com/facebook/hiphop-php/pull/1140
Comment 8 Antoine "hashar" Musso (WMF) 2013-10-10 21:04:11 UTC
Chad pull request got merged :-]
Comment 9 Andre Klapper 2014-01-10 00:38:20 UTC
[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links