Last modified: 2011-06-29 19:27:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T30466, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 28466 - Extension:TitleBlacklist doesn't seem to work on Commons
Extension:TitleBlacklist doesn't seem to work on Commons
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Extension setup (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-09 00:06 UTC by Neil Kandalgaonkar
Modified: 2011-06-29 19:27 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Neil Kandalgaonkar 2011-04-09 00:06:27 UTC
According to the config on 

   http://commons.wikimedia.org/wiki/MediaWiki:Titleblacklist

Files like  "DVC1234.JPG" should be blocked:

   File:DVC[\d\s]+\.JPG  <reupload|errmsg=senselessimagename>  # DoCoMo

But here's one I could upload, as a non-admin.

   http://commons.wikimedia.org/wiki/File:DVC9083427.JPG

The system does reject some commons patterns like DSC123456.JPG, but that is because of yet another blacklist check (http://commons.wikimedia.org/wiki/MediaWiki:Filename-prefix-blacklist).

Sam Reedy suggests some crucial fixes did not get pushed to 1.17 wmf branch. Although it looks like they did?

It's confusing. This definitely does seem to work on a local trunk install.
Comment 1 MZMcBride 2011-04-09 02:01:05 UTC
(In reply to comment #0)
> According to the config on 
> 
>    http://commons.wikimedia.org/wiki/MediaWiki:Titleblacklist
> 
> Files like  "DVC1234.JPG" should be blocked:
> 
>    File:DVC[\d\s]+\.JPG  <reupload|errmsg=senselessimagename>  # DoCoMo
> 
> But here's one I could upload, as a non-admin.
> 
>    http://commons.wikimedia.org/wiki/File:DVC9083427.JPG

Looks like the title blacklist entry is for reuploads while you're doing a regular upload. This bug seems invalid.
Comment 2 MZMcBride 2011-04-09 02:10:32 UTC
(In reply to comment #1)
> Looks like the title blacklist entry is for reuploads while you're doing a
> regular upload. This bug seems invalid.

Ah, just kidding. The "reupload" flag allows files to be reuploaded that match the blacklist, so this regular upload should've been blocked. Not sure why this didn't hit the blacklist.
Comment 3 MZMcBride 2011-04-09 02:29:08 UTC
I confirmed that it's not blocking regular uploads with names like "File:DVC222.JPG" as it should.

The title blacklist is working generally, though, e.g., <http://commons.wikimedia.org/w/index.php?title=Http://&action=edit> is appropriately blocked from creation.
Comment 4 Sam Reed (reedy) 2011-04-10 22:46:31 UTC
Added to my TODO list to confirm on my trunk/wmf-deployment branches for this week
Comment 5 Sam Reed (reedy) 2011-04-12 00:14:44 UTC
I can reproduce on trunk, as can Neil now, but seemingly nothing obvious has changed...

Computers suck
Comment 6 Sam Reed (reedy) 2011-04-12 00:21:36 UTC
(In reply to comment #0)
> 
> The system does reject some commons patterns like DSC123456.JPG, but that is
> because of yet another blacklist check
> (http://commons.wikimedia.org/wiki/MediaWiki:Filename-prefix-blacklist).
>

No idea why we have 2 things doing the same thing though too.. :/
Comment 7 Neil Kandalgaonkar 2011-06-09 21:24:08 UTC
Any followup on the status of this bug?

If I recall correctly, did we find that it worked fine for regular uploads but not API uploads? Or did it not work at all?
Comment 8 Bawolff (Brian Wolff) 2011-06-24 20:37:54 UTC
I think this might be caused by r65898.
Comment 9 Vituzzu@it.wiki 2011-06-24 20:49:08 UTC
(In reply to comment #1)
> (In reply to comment #0)
> > According to the config on 
> > 
> >    http://commons.wikimedia.org/wiki/MediaWiki:Titleblacklist
> > 
> > Files like  "DVC1234.JPG" should be blocked:
> > 
> >    File:DVC[\d\s]+\.JPG  <reupload|errmsg=senselessimagename>  # DoCoMo
> > 
> > But here's one I could upload, as a non-admin.
> > 
> >    http://commons.wikimedia.org/wiki/File:DVC9083427.JPG
> 
> Looks like the title blacklist entry is for reuploads while you're doing a
> regular upload. This bug seems invalid.

The same just happened on it.wiki:

File:DSC.\d+\.JPG  <reupload|errmsg=titleblacklist-custom-nomefile> 

was bypassed by

https://secure.wikimedia.org/wikipedia/it/w/index.php?title=Speciale:File&user=Derek91

doing some test it works fine, these random fails sounds similar to abusefilters' bug #28154
Comment 10 Bawolff (Brian Wolff) 2011-06-24 21:29:04 UTC
I believe I fixed this in r90737 (But would love to have someone verify that, as some of these reports seem to suggest the problem was intermittent, where what I fixed was not).

It was caused by special:upload doing a $title->useCan('createpage'), where the extension was looking for a 'create' action check.
Comment 11 Vituzzu@it.wiki 2011-06-24 21:43:17 UTC
(In reply to comment #10)
> I believe I fixed this in r90737 (But would love to have someone verify that,
> as some of these reports seem to suggest the problem was intermittent, where
> what I fixed was not).
> 
> It was caused by special:upload doing a $title->useCan('createpage'), where the
> extension was looking for a 'create' action check.

Still here:

https://secure.wikimedia.org/wikipedia/it/wiki/File:DSC07963.JPG

I suppose it's just a synch matter.
Comment 12 Bawolff (Brian Wolff) 2011-06-24 21:52:40 UTC
(In reply to comment #11)
> (In reply to comment #10)
> > I believe I fixed this in r90737 (But would love to have someone verify that,
> > as some of these reports seem to suggest the problem was intermittent, where
> > what I fixed was not).
> > 
> > It was caused by special:upload doing a $title->useCan('createpage'), where the
> > extension was looking for a 'create' action check.
> 
> Still here:
> 
> https://secure.wikimedia.org/wikipedia/it/wiki/File:DSC07963.JPG
> 
> I suppose it's just a synch matter.

Yes, the fix is in trunk, Wikimedia wikis run something significantly older.
Comment 13 MZMcBride 2011-06-24 21:59:33 UTC
I confirmed that this is fixed on my test install. I also agree that this should be pushed alive as soon as possible. Thanks, Bawolff!
Comment 14 Vituzzu@it.wiki 2011-06-24 22:45:23 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > I believe I fixed this in r90737 (But would love to have someone verify that,
> > > as some of these reports seem to suggest the problem was intermittent, where
> > > what I fixed was not).
> > > 
> > > It was caused by special:upload doing a $title->useCan('createpage'), where the
> > > extension was looking for a 'create' action check.
> > 
> > Still here:
> > 
> > https://secure.wikimedia.org/wikipedia/it/wiki/File:DSC07963.JPG
> > 
> > I suppose it's just a synch matter.
> 
> Yes, the fix is in trunk, Wikimedia wikis run something significantly older.

Wops I didn't realize it was still in trunk...so what about abuselog's bug? ;)
Comment 15 Bawolff (Brian Wolff) 2011-06-24 22:47:54 UTC
>Wops I didn't realize it was still in trunk...so what about abuselog's bug? ;)
It appears unrelated :P
Comment 16 Vituzzu@it.wiki 2011-06-24 22:50:25 UTC
(In reply to comment #15)
> >Wops I didn't realize it was still in trunk...so what about abuselog's bug? ;)
> It appears unrelated :P

I see but I hoped they were related... abusefilter is getting quite useless .__.
Comment 17 Neil Kandalgaonkar 2011-06-25 00:27:37 UTC
Thanks bawolff, that's excellent news.

I will test this myself later and then we'll discuss getting it into production.
Comment 18 Neil Kandalgaonkar 2011-06-29 19:27:30 UTC
This works for me too, and removing the fix in r90737 will cause the error to happen again, at least locally. Great.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links